feat: Improve error message at missing pixi section#3516
Merged
Hofer-Julian merged 14 commits intoprefix-dev:mainfrom Apr 11, 2025
Merged
Conversation
joyanedel
changed the title
baszalmstra
reviewed
Apr 10, 2025
Contributor
baszalmstra
left a comment
baszalmstra
left a comment
There was a problem hiding this comment.
I love the error message! Just left one comment.
baszalmstra
approved these changes
Apr 11, 2025
Hofer-Julian
approved these changes
Apr 11, 2025
Contributor
Hofer-Julian
left a comment
Hofer-Julian
left a comment
There was a problem hiding this comment.
Great improvement, thanks a lot @joyanedel 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Help message displayed by pixi when pixi.toml is missing [project] or pyproject.toml is missing a pixi block is misleading as users in issue #3202 mentioned
Solution
Add a new TomlError to improve error message in this aspect.
pixi.toml
pyproject.toml
No explicit manifest-path
It will use the well-formed
pixi.tomlmanifest file from parent directory and, therefore, no display error messageExplicit manifest-path