Skip to content

fix: dont prematurely shutdown runtime#3325

Merged
ruben-arts merged 1 commit intoprefix-dev:mainfrom
baszalmstra:fix/issue_3283
Mar 11, 2025
Merged

fix: dont prematurely shutdown runtime#3325
ruben-arts merged 1 commit intoprefix-dev:mainfrom
baszalmstra:fix/issue_3283

Conversation

@baszalmstra
Copy link
Copy Markdown
Contributor

Fixes #3283

We were calling Runtime::shutdown_background which immediately shuts down the runtime without waiting for spawned work to complete.

There is a caveat:

Note however, that because we do not wait for any blocking tasks to complete, this may result in a resource leak (in that any blocking tasks are still running until they return.

When solving, we are spawning several tasks which are also driving the progress bars. Since these tasks are not properly shut down the progress bars are also not cleaned up properly.

This PR simply removes the call because I also dont think it bring us much.

Copy link
Copy Markdown
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot reproduce the problem locally, but the code change looks good to me

@ruben-arts
Copy link
Copy Markdown
Contributor

It does solve the issue but it reintroduces the left over progresbar as you said.

⠁ updating lock-file   [00:00:00] [────────────────────────────────────────]    0/55                                                                                                                      
⠁ updating lock-file   [00:00:00] [────────────────────────────────────────]    0/55                                                                                                                      
⠁ updating lock-file   [00:00:00] [────────────────────────────────────────]    0/55                                                                                                                      
⠁ updating lock-file   [00:00:00] [────────────────────────────────────────]    0/55                                                                                                                      
⠁ updating lock-file   [00:00:00] [────────────────────────────────────────]    0/55                                                                                                                      
⠁ updating lock-file   [00:00:00] [────────────────────────────────────────]    0/55                                                                                                                      
⠁ updating lock-file   [00:00:00] [────────────────────────────────────────]    0/55                                                                                                                      
Error:   × failed to solve the conda requirements of 'default' 'osx-arm64'
  ╰─▶ Cannot solve the request because of: No candidates were found for git >=123.46.0,<3.

@ruben-arts
Copy link
Copy Markdown
Contributor

This actually only happens in a JetBrains terminal, both succeeding and non succeeding runs, for both the old and new pixi.

Merging this PR, thanks @baszalmstra

@ruben-arts ruben-arts merged commit 9a36223 into prefix-dev:main Mar 11, 2025
28 checks passed
wolfv pushed a commit to wolfv/pixi that referenced this pull request Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

can't see error message when pixi lock

3 participants