fix: dont prematurely shutdown runtime#3325
Merged
ruben-arts merged 1 commit intoprefix-dev:mainfrom Mar 11, 2025
Merged
Conversation
Hofer-Julian
approved these changes
Mar 11, 2025
Contributor
Hofer-Julian
left a comment
There was a problem hiding this comment.
I cannot reproduce the problem locally, but the code change looks good to me
Contributor
|
It does solve the issue but it reintroduces the left over progresbar as you said. |
Contributor
|
This actually only happens in a JetBrains terminal, both succeeding and non succeeding runs, for both the old and new pixi. Merging this PR, thanks @baszalmstra |
wolfv
pushed a commit
to wolfv/pixi
that referenced
this pull request
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3283
We were calling Runtime::shutdown_background which immediately shuts down the runtime without waiting for spawned work to complete.
There is a caveat:
When solving, we are spawning several tasks which are also driving the progress bars. Since these tasks are not properly shut down the progress bars are also not cleaned up properly.
This PR simply removes the call because I also dont think it bring us much.