Skip to content

feat: pixi exec --list#3311

Merged
Hofer-Julian merged 7 commits intoprefix-dev:mainfrom
lucascolley:exec-list
Mar 11, 2025
Merged

feat: pixi exec --list#3311
Hofer-Julian merged 7 commits intoprefix-dev:mainfrom
lucascolley:exec-list

Conversation

@lucascolley
Copy link
Copy Markdown
Collaborator

@lucascolley lucascolley commented Mar 10, 2025

closes gh-3303

lucascolley
lucascolley commented Mar 10, 2025
View reviewed changes
lucascolley
lucascolley commented Mar 10, 2025
View reviewed changes
@Hofer-Julian
fix: exec --list
22333e7 
- Make "=" required for `--list`
- Encapsulate functionality
- Clean up code
@Hofer-Julian
Add rust-src to build feature
cbdc9e7
@Hofer-Julian
Copy link
Copy Markdown
Contributor

Hofer-Julian commented Mar 11, 2025

@lucascolley nice work!
I pushed to your branch with the following changes:

  • Make "=" required for --list (otherwise list wouldn't work without a given regex, since it would think the command is the regex)
  • Move rust-src dependency
  • Encapsulate functionality
  • Clean up code

@Hofer-Julian Hofer-Julian marked this pull request as ready for review March 11, 2025 10:36
lucascolley
lucascolley commented Mar 11, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator Author

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Hofer-Julian, all looks good to me!

Hofer-Julian
Hofer-Julian approved these changes Mar 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @lucascolley 🚀

@Hofer-Julian Hofer-Julian merged commit 5edd7d8 into prefix-dev:main Mar 11, 2025
32 checks passed
@lucascolley
Copy link
Copy Markdown
Collaborator Author

lucascolley commented Mar 11, 2025

thanks for all the help!

@lucascolley lucascolley deleted the exec-list branch March 16, 2025 21:18
wolfv pushed a commit to wolfv/pixi that referenced this pull request Mar 17, 2025
@lucascolley @Hofer-Julian @wolfv
feat: pixi exec --list (prefix-dev#3311)
b9de8f5 
Co-authored-by: Julian Hofer <julianhofer@gnome.org>
Co-authored-by: Hofer-Julian <30049909+Hofer-Julian@users.noreply.github.com>
@BrewTestBot BrewTestBot mentioned this pull request Mar 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hofer-Julian Hofer-Julian Hofer-Julian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: pixi exec --list

2 participants

@lucascolley @Hofer-Julian