fix: Sort exported conda explicit spec topologically #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the ownership of the feature! |
ruben-arts
approved these changes
Sep 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
pixi project export conda-explicit-specto sort the urls in the.txtfile topologically. This addresses the error raised by @matthewfeickert in #1873 (comment). I've tested the exported file using the minimal example provided, and can reproduce the error using 0.30.0 and checked that the docker image builds correctly with the changes in this PR.Strangely, I didn't get any errors when I ran the export using 0.30.0 on
osx-64and then created an env usingmambalocally. I'm not sure what the difference is betweenmicromambain the linux docker image andmambalocally on macos, but the latter created the env from the spec without errors. Again, my apologies for overlooking the sorting issue in the specification of the.txtfile.