-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow to upgrade several global packages at once #1324
Conversation
481cf61
to
d54cdbe
Compare
6f49292
to
99322b8
Compare
99322b8
to
3f08109
Compare
} | ||
|
||
// Remove possible duplicates | ||
channels = channels.into_iter().unique().collect::<Vec<_>>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I note channels
is common across all global packages. Is this the intended behaviour?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I believe the intended behavior is for each global install to use the channels as they were configured at installation time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I'll fix this in a separate PR as this one has been merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an open issue about this: #1318
Thanks @olivier-lacroix!
This PR refactors most of
upgrade.rs
andupgrade_all.rs
into a commonupgrade_packages
function, which upgrades several global packages at once.Now, several global packages can be upgraded at once.