Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change global config to kebab-case #1308

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

tdejager
Copy link
Contributor

This PR adds the option to use kebab-case in the global config. Which will be the preferred option, for older options we've kept the old way of snake_case configuration.

Also, the documentation was updated to reflect this. There was as error in the repodata-config in the documentation this was incorrectly named repodata-options this has never worked. This has also been rectified.

This PR adds the option to use kebab-case in the global config.
Which will be the preferred option, for older options we've kept the
old way of `snake_case` configuration.

Also, the documentation was updated to reflect this. There was as error
in the `repodata-config` in the documentation this was incorrectly named
`repodata-options` this has *never* worked. This has also been
rectified.
src/config.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@ruben-arts ruben-arts merged commit 621b732 into prefix-dev:main Apr 30, 2024
26 of 27 checks passed
tdejager pushed a commit that referenced this pull request May 2, 2024
Inspired by #1308

Note that the schema is updated to also understand both but with
deprecation documentation. And the ability to removed this after future
releases to force users that lint their toml to be using the correct
version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants