refactor: Use generics over PyPiDependencies and CondaDependencies #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivier-lacroix
changed the title
olivier-lacroix
force-pushed
the
deps
branch
2 times, most recently
from
0180a0e
to
b283786
Compare
tdejager
approved these changes
Apr 30, 2024
|
This LGTM @baszalmstra good if you could give this a quick glance :) |
baszalmstra
reviewed
May 2, 2024
|
Done @baszalmstra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tdejager , this aligns the way Pypi and Conda dependencies are being merged in the
HasFeaturestrait