Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support pypi dependencies in lock-files #467

Closed
baszalmstra opened this issue Nov 16, 2023 · 0 comments · Fixed by #494
Closed

support pypi dependencies in lock-files #467

baszalmstra opened this issue Nov 16, 2023 · 0 comments · Fixed by #494

Comments

@baszalmstra
Copy link
Contributor

Currently, our implementation of PyPI dependencies completely ignores lock files. We have to add back support to check the satisfyability of our constraints against a lock file where PyPI dependencies are also involved.

The biggest hurdle in this process is that in the lock-file we currently have no mapping from conda package names to PyPI package names. This will most likely have to be added to the lock-file format to ensure we can deterministically verify the satisfyability of the lock-file without requiring any internet connection.

@baszalmstra baszalmstra added this to the Beta release PyPi support milestone Nov 16, 2023
baszalmstra added a commit that referenced this issue Nov 24, 2023
This PR adds support for checking the satisfiability of the lock-file
which includes pypi-dependencies.

Purls have been added to the lock-file
(conda/rattler#414) (See also:
conda/ceps#63). This enables checking
which conda packages will install which pypi packages without needing to
check the internet. This ensures we can still check if a lock-file is up
to date quickly.

I did not profile this code but I think there are a lot of places we can
improve the performance. Thats for a later PR.

I also didn't add tests. I think we should but we can also do that in
another PR.

Closes #467

---------

Co-authored-by: Ruben Arts <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant