-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panic when installing package with pkg @ file:///path/to/local/pkg
dependency
#1186
Comments
I think the error indicates that the file or directory at file:///Users/hhip/src/rerun/examples/python/clock does not exist. Is this perhaps on a windows machine? Are you maybe missing the drive specifier? |
@baszalmstra No that's not it, it creates an erroneous path. Because of the double indirection in the project produces a 'file:://' in the wrong lock file variable. I've already investigated a bit but still need to solve! |
A couple of thoughts that came up while poking at that stuff. It may seem ad hoc/ugly to have full path hard-coded in dependencies. It turns out it can be a legitimate approach thanks to hatch's context formatting. Whit this feature, it's possible to have something like this as dependency: dependencies = [
"pkg @ {root:parent:uri}/pkg",
] Hatch substitutes the Also, assuming pixi properly supports (indirect) local dependencies, it would be unfortunate that full paths made their way to the |
Hmm for that case, I think we might need to make another exception if we want to support w.r.t locking. I've made a fix for the repro here: #1196 Don't know if it is possible for you to give that PR a spin? |
We've discussed offline on discord. And this seems to resolve things, we are running into a different issue, but that's unrelated to this specific issue. |
I'm not sure it's the same issue, but I cannot use git clone https://github.com/jupyterlab/jupyter-collaboration.git
cd jupyter-collaboration
pixi init
|
Yeah so its a related but not exactly the same issue, but that is because pep508-rs and the pyproject-toml-rs crates. Do not support these pep-508 specific extensions. |
To eleborate when reading the PyPA it is kind of implied that these file url's should be absolute only. Even though |
@davidbrochart if you could make a seperate issue for your problem that would be great :)! |
…#1263) The fix that was made in #1186 was only applied to Source Distributions. This was incorrect, refactored into seperate method and used for both built and source dists. Still not really sure how to add a good test in CI, we could use hatches dynamic metadata to generate a pyproject.toml but still seems more trouble than its worth to me :)
Checks
I have checked that this issue has not already been reported.
I have confirmed this bug exists on the latest version of pixi, using
pixi --version
.Reproducible example
The issue can be reproduced with the following project: rerun.tar.gz
Uncompress in
/tmp
, clear the lock file, andpixi install
:Issue description
Discussed in the following discord thread: https://discord.com/channels/1082332781146800168/1228365148243366010
The relevant pyproject is:
Specifically, pixi seems to have an issue with
@ file:///...
dependency descriptor.Expected behavior
The repro is a valid project and should work. In particular, uv is happy with it.
The text was updated successfully, but these errors were encountered: