Skip to content

Fix crash for FEniCS-OpenFOAM perpendicular flap example with subcycling #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenjaminRodenberg merged 3 commits into from
Aug 14, 2024
Merged

Fix crash for FEniCS-OpenFOAM perpendicular flap example with subcycling #554

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
393f3ba
Formatting
NiklasVin Aug 4, 2024
721c669
Fix crash while using subcycling for FEniCS-OpenFOAM perpendicular fl…
NiklasVin Aug 4, 2024
6ce8bd9
Add changelog entry.
BenjaminRodenberg Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions perpendicular-flap/solid-fenics/solid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,16 +158,14 @@ def update_v(a, u_old, v_old, a_old, ufl=True):
def update_fields(u, u_old, v_old, a_old):
"""Update all fields at the end of a timestep."""

u_vec, u0_vec = u.vector(), u_old.vector()
v0_vec, a0_vec = v_old.vector(), a_old.vector()

# call update functions
a_vec = update_a(u_vec, u0_vec, v0_vec, a0_vec, ufl=False)
v_vec = update_v(a_vec, u0_vec, v0_vec, a0_vec, ufl=False)
a_new = update_a(u, u_old, v_old, a_old)
v_new = update_v(u, u_old, v_old, a_old)

# assign u->u_old
v_old.vector()[:], a_old.vector()[:] = v_vec, a_vec
u_old.vector()[:] = u.vector()
# update values
a_old.assign(project(a_new, V))
v_old.assign(project(v_new, V))
Comment thread
BenjaminRodenberg marked this conversation as resolved.
u_old.assign(u)


def avg(x_old, x_new, alpha):
Expand Down Expand Up @@ -238,7 +236,6 @@ def avg(x_old, x_new, alpha):
n = n_cp
else:
update_fields(u_np1, u_n, v_n, a_n)
u_n.assign(u_np1)
t += float(dt)
n += 1

Expand Down