Add safe guard to dangerouslySetInnerHTML #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@steelbrain Awesome, will merge. I think it needs to be slightly tweaked so that unsetting it doesn't overwrite newly created children, something like: else if (name==='dangerouslySetInnerHTML') {
if (value && value.__html) node.innerHTML = value.__html;
} |
developit
added a commit
that referenced
this pull request
Mar 14, 2016
Add safe guard to dangerouslySetInnerHTML
developit
added a commit
that referenced
this pull request
Mar 14, 2016
|
Released in 4.3.2 |
marvinhagemeister
added a commit
that referenced
this pull request
Mar 2, 2019
Add more tests for Fragments and array children
marvinhagemeister
added a commit
that referenced
this pull request
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@developit Any ideas how to add tests for this one? You don't seem to have functional tests and this is a deep down change. Also I am not sure how to repro this manually
Fixes #90