-
-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: support use hook #4970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: support use hook #4970
Conversation
📊 Tachometer Benchmark ResultsSummaryA summary of the benchmark results will show here once they finish. ResultsThe full results of your benchmarks will show here once they finish. |
rschristian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a swing at implementing this! Few comments though, mostly minor (in addition to what Jovi's already said):
|
As I tried to make clear in my suggestions/comments, the philosophy of preact is to optimize for performance and size. We should also not leak implementation details into core for the sake of it. EDIT: thinking more about the |
Co-authored-by: Ryan Christian <[email protected]>
Co-authored-by: Ryan Christian <[email protected]>
Co-authored-by: Jovi De Croock <[email protected]>
Co-authored-by: Jovi De Croock <[email protected]>
Co-authored-by: Jovi De Croock <[email protected]>
close #4756