Skip to content

Conversation

@gaoachao
Copy link

@gaoachao gaoachao commented Dec 2, 2025

close #4756

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

📊 Tachometer Benchmark Results

Summary

A summary of the benchmark results will show here once they finish.

Results

The full results of your benchmarks will show here once they finish.

tachometer-reporter-action v2 for CI

Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a swing at implementing this! Few comments though, mostly minor (in addition to what Jovi's already said):

@JoviDeCroock
Copy link
Member

JoviDeCroock commented Dec 2, 2025

As I tried to make clear in my suggestions/comments, the philosophy of preact is to optimize for performance and size. We should also not leak implementation details into core for the sake of it.

EDIT: thinking more about the PROMISE_CACHE, I think I know what you were going for with persisting across discarded renders in relation to the missing lifecycle problem. As we assume the Promise identity to be stable we could hang the value off of that and re-hydrate it though so I think we are safe there. It would have been easier to realise what you were going for with a description for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

React 19 compatibility: Add support for use(promise) to preact/compat

3 participants