Skip to content

feat: Add types for 'getDisplayName'#4957

Merged
rschristian merged 1 commit intomainfrom
types/getDisplayName
Nov 10, 2025
Merged

feat: Add types for 'getDisplayName'#4957
rschristian merged 1 commit intomainfrom
types/getDisplayName

Conversation

@rschristian
Copy link
Member

Closes #4952

@github-actions
Copy link

github-actions bot commented Nov 9, 2025

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -0% - +2% (-1.59ms - +18.33ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.07ms - +0.03ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +2% (-1.59ms - +1.51ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -1% - +1% (-0.15ms - +0.24ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +1% (-0.93ms - +0.49ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -2% - +6% (-0.03ms - +0.12ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -2% - +1% (-0.48ms - +0.44ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +5% (-0.15ms - +1.48ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -1% - +1% (-0.02ms - +0.01ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -6% - +7% (-0.36ms - +0.48ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -2% - +2% (-0.02ms - +0.02ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local975.27ms - 992.65ms-unsure 🔍
-0% - +2%
-1.59ms - +18.33ms
preact-main970.72ms - 980.46msunsure 🔍
-2% - +0%
-18.33ms - +1.59ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.04ms - 19.04ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main19.04ms - 19.04msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.54ms - 16.57ms-unsure 🔍
-0% - +0%
-0.07ms - +0.03ms
preact-main16.53ms - 16.62msunsure 🔍
-0% - +0%
-0.03ms - +0.07ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.54ms - 1.56ms-unsure 🔍
-1% - +1%
-0.02ms - +0.01ms
preact-main1.54ms - 1.57msunsure 🔍
-1% - +1%
-0.01ms - +0.02ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local72.61ms - 74.74ms-unsure 🔍
-2% - +2%
-1.59ms - +1.51ms
preact-main72.59ms - 74.84msunsure 🔍
-2% - +2%
-1.51ms - +1.59ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local6.35ms - 6.97ms-unsure 🔍
-6% - +7%
-0.36ms - +0.48ms
preact-main6.31ms - 6.88msunsure 🔍
-7% - +5%
-0.48ms - +0.36ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.32ms - 16.56ms-unsure 🔍
-1% - +1%
-0.15ms - +0.24ms
preact-main16.24ms - 16.55msunsure 🔍
-1% - +1%
-0.24ms - +0.15ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.72ms - 3.73ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main3.72ms - 3.73msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #5208
  • Commit: 89a721c

duration

VersionAvg timevs preact-localvs preact-main
preact-local61.74ms - 62.58ms-unsure 🔍
-1% - +1%
-0.93ms - +0.49ms
preact-main61.81ms - 62.95msunsure 🔍
-1% - +1%
-0.49ms - +0.93ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.99ms - 2.99ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main2.99ms - 2.99msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local26.06ms - 26.79ms-unsure 🔍
-2% - +2%
-0.55ms - +0.49ms
preact-main26.09ms - 26.83msunsure 🔍
-2% - +2%
-0.49ms - +0.55ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local32.34ms - 33.24ms-unsure 🔍
-3% - +1%
-0.93ms - +0.35ms
preact-main32.63ms - 33.54msunsure 🔍
-1% - +3%
-0.35ms - +0.93ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local33.76ms - 34.52ms-unsure 🔍
-1% - +3%
-0.21ms - +0.85ms
preact-main33.45ms - 34.18msunsure 🔍
-2% - +1%
-0.85ms - +0.21ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local26.05ms - 26.40ms-unsure 🔍
-0% - +1%
-0.12ms - +0.35ms
preact-main25.95ms - 26.27msunsure 🔍
-1% - +0%
-0.35ms - +0.12ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local25.05ms - 26.41ms-unsure 🔍
-7% - +0%
-1.80ms - +0.14ms
preact-main25.86ms - 27.25msunsure 🔍
-1% - +7%
-0.14ms - +1.80ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local21.21ms - 21.70ms-unsure 🔍
-1% - +2%
-0.31ms - +0.38ms
preact-main21.19ms - 21.66msunsure 🔍
-2% - +1%
-0.38ms - +0.31ms
-
text-update
  • Browser: chrome-headless
  • Sample size: 240
  • Built by: CI #5208
  • Commit: 89a721c

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.90ms - 2.02ms-unsure 🔍
-2% - +6%
-0.03ms - +0.12ms
preact-main1.87ms - 1.97msunsure 🔍
-6% - +2%
-0.12ms - +0.03ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local0.99ms - 1.02ms-unsure 🔍
-2% - +2%
-0.02ms - +0.02ms
preact-main0.99ms - 1.02msunsure 🔍
-2% - +2%
-0.02ms - +0.02ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local31.60ms - 32.01ms-unsure 🔍
-2% - +1%
-0.48ms - +0.44ms
preact-main31.41ms - 32.24msunsure 🔍
-1% - +2%
-0.44ms - +0.48ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.26ms - 1.26ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.26ms - 1.26msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local32.68ms - 33.84ms-unsure 🔍
-0% - +5%
-0.15ms - +1.48ms
preact-main32.03ms - 33.17msunsure 🔍
-4% - +0%
-1.48ms - +0.15ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.93ms - 2.94ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main2.93ms - 2.94msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-

tachometer-reporter-action v2 for CI

@github-actions
Copy link

github-actions bot commented Nov 9, 2025

Size Change: 0 B

Total Size: 47.5 kB

ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 3.91 kB
compat/dist/compat.mjs 3.84 kB
compat/dist/compat.umd.js 3.96 kB
debug/dist/debug.js 3.9 kB
debug/dist/debug.mjs 3.9 kB
debug/dist/debug.umd.js 3.98 kB
devtools/dist/devtools.js 263 B
devtools/dist/devtools.mjs 273 B
devtools/dist/devtools.umd.js 348 B
dist/preact.js 4.71 kB
dist/preact.mjs 4.73 kB
dist/preact.umd.js 4.78 kB
hooks/dist/hooks.js 1.53 kB
hooks/dist/hooks.mjs 1.56 kB
hooks/dist/hooks.umd.js 1.6 kB
jsx-runtime/dist/jsxRuntime.js 892 B
jsx-runtime/dist/jsxRuntime.mjs 861 B
jsx-runtime/dist/jsxRuntime.umd.js 966 B
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.mjs 473 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

@coveralls
Copy link

coveralls commented Nov 9, 2025

Coverage Status

coverage: 99.442%. remained the same
when pulling 89a721c on types/getDisplayName
into 4788838 on main.

Comment on lines -5 to 6
* @param {import('./internal').VNode} vnode
*
* @param {import('./internal').VNode} vnode
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate line that I thought I'd correct whilst I was at it

@rschristian rschristian merged commit eee0c6e into main Nov 10, 2025
13 checks passed
@rschristian rschristian deleted the types/getDisplayName branch November 10, 2025 03:07
@JoviDeCroock JoviDeCroock mentioned this pull request Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

getDisplayName is missing a type declaration

3 participants