Skip to content

Adds scrollsnapchange and scrollsnapchanging event support#4946

Merged
rschristian merged 4 commits intopreactjs:mainfrom
argyleink:scrollsnapchange-scrollsnapchanging-events
Oct 30, 2025
Merged

Adds scrollsnapchange and scrollsnapchanging event support#4946
rschristian merged 4 commits intopreactjs:mainfrom
argyleink:scrollsnapchange-scrollsnapchanging-events

Conversation

rschristian
rschristian previously approved these changes Oct 30, 2025
Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

The main branch is targetting v11, which is still in beta. If you're willing to mirror this to the v10.x branch, targetting the current v10 release line, we'd appreciate it, else one of us will do it when we can.

@coveralls
Copy link

coveralls commented Oct 30, 2025

Coverage Status

coverage: 99.442%. remained the same
when pulling 00fd3ea on argyleink:scrollsnapchange-scrollsnapchanging-events
into 6241a5a on preactjs:main.

@rschristian rschristian dismissed their stale review October 30, 2025 00:36

Shouldn't have approved

@argyleink argyleink changed the base branch from main to v10.x October 30, 2025 15:02
@argyleink argyleink changed the base branch from v10.x to main October 30, 2025 15:02
@argyleink argyleink mentioned this pull request Oct 30, 2025
@argyleink
Copy link
Contributor Author

The main branch is targetting v11, which is still in beta. If you're willing to mirror this to the v10.x branch, targetting the current v10 release line, we'd appreciate it, else one of us will do it when we can.

mirror into v10.x #4947

@rschristian rschristian force-pushed the scrollsnapchange-scrollsnapchanging-events branch 2 times, most recently from 1692261 to 00fd3ea Compare October 30, 2025 18:32
Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope you don't mind, I just went ahead and added the corrections to your branch as I realized TS hasn't yet shipped SnapEvent (or hasn't in our version, anyhow) and it'd require a bit of wrangling to set up. Not a lot of work, but equally, not something we'd expect for folks with 0 context of this repo.

Thanks again!

@rschristian rschristian merged commit 5bea6be into preactjs:main Oct 30, 2025
5 checks passed
@argyleink argyleink deleted the scrollsnapchange-scrollsnapchanging-events branch October 30, 2025 21:20
@JoviDeCroock JoviDeCroock mentioned this pull request Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants