Skip to content

Conversation

@JoviDeCroock
Copy link
Member

Resolves #4933

I think this is the safest solution, rendering to nothing if the error is caught and nothing is returned.

@github-actions
Copy link

github-actions bot commented Oct 24, 2025

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -0% - +1% (-2.39ms - +4.81ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +1% (-0.02ms - +0.13ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +2% (-1.27ms - +1.20ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.02ms - +0.04ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +1% (-0.49ms - +0.73ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -5% - +2% (-0.09ms - +0.03ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -2% - +1% (-0.65ms - +0.29ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -5% - +3% (-1.34ms - +0.85ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -8% - +4% (-0.56ms - +0.29ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -4% - +2% (-0.04ms - +0.02ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local951.47ms - 956.96ms-unsure 🔍
-0% - +1%
-2.39ms - +4.81ms
preact-main950.67ms - 955.33msunsure 🔍
-1% - +0%
-4.81ms - +2.39ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.19ms - 19.19ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main19.19ms - 19.19msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.53ms - 16.67ms-unsure 🔍
-0% - +1%
-0.02ms - +0.13ms
preact-main16.52ms - 16.57msunsure 🔍
-1% - +0%
-0.13ms - +0.02ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.55ms - 1.56ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.55ms - 1.55msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local72.01ms - 73.82ms-unsure 🔍
-2% - +2%
-1.27ms - +1.20ms
preact-main72.12ms - 73.80msunsure 🔍
-2% - +2%
-1.20ms - +1.27ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local6.16ms - 6.73ms-unsure 🔍
-8% - +4%
-0.56ms - +0.29ms
preact-main6.27ms - 6.89msunsure 🔍
-5% - +9%
-0.29ms - +0.56ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.52ms - 16.57ms-unsure 🔍
-0% - +0%
-0.02ms - +0.04ms
preact-main16.51ms - 16.55msunsure 🔍
-0% - +0%
-0.04ms - +0.02ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.71ms - 3.72ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main3.71ms - 3.72msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #5174
  • Commit: c390ec7

duration

VersionAvg timevs preact-localvs preact-main
preact-local59.34ms - 60.26ms-unsure 🔍
-1% - +1%
-0.49ms - +0.73ms
preact-main59.28ms - 60.09msunsure 🔍
-1% - +1%
-0.73ms - +0.49ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.00ms - 3.00ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main3.00ms - 3.00msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local24.68ms - 25.35ms-unsure 🔍
-1% - +3%
-0.25ms - +0.71ms
preact-main24.44ms - 25.13msunsure 🔍
-3% - +1%
-0.71ms - +0.25ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local31.19ms - 32.40ms-unsure 🔍
-2% - +3%
-0.79ms - +0.98ms
preact-main31.06ms - 32.34msunsure 🔍
-3% - +2%
-0.98ms - +0.79ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local29.49ms - 30.59ms-unsure 🔍
-3% - +2%
-0.95ms - +0.53ms
preact-main29.75ms - 30.75msunsure 🔍
-2% - +3%
-0.53ms - +0.95ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local24.09ms - 24.39ms-unsure 🔍
-1% - +1%
-0.16ms - +0.28ms
preact-main24.02ms - 24.34msunsure 🔍
-1% - +1%
-0.28ms - +0.16ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local24.02ms - 25.32ms-unsure 🔍
-6% - +2%
-1.45ms - +0.43ms
preact-main24.50ms - 25.87msunsure 🔍
-2% - +6%
-0.43ms - +1.45ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local20.32ms - 20.77ms-unsure 🔍
-2% - +2%
-0.33ms - +0.35ms
preact-main20.28ms - 20.79msunsure 🔍
-2% - +2%
-0.35ms - +0.33ms
-
text-update
  • Browser: chrome-headless
  • Sample size: 230
  • Built by: CI #5174
  • Commit: c390ec7

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.77ms - 1.84ms-unsure 🔍
-5% - +2%
-0.09ms - +0.03ms
preact-main1.79ms - 1.89msunsure 🔍
-2% - +5%
-0.03ms - +0.09ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.00ms - 1.04ms-unsure 🔍
-4% - +2%
-0.04ms - +0.02ms
preact-main1.01ms - 1.06msunsure 🔍
-2% - +4%
-0.02ms - +0.04ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local32.20ms - 32.51ms-unsure 🔍
-2% - +1%
-0.65ms - +0.29ms
preact-main32.09ms - 32.98msunsure 🔍
-1% - +2%
-0.29ms - +0.65ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.25ms - 1.25ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.25ms - 1.26msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local28.44ms - 29.77ms-unsure 🔍
-5% - +3%
-1.34ms - +0.85ms
preact-main28.47ms - 30.22msunsure 🔍
-3% - +5%
-0.85ms - +1.34ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.96ms - 2.97ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-main2.96ms - 2.97msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms
-

tachometer-reporter-action v2 for CI

@github-actions
Copy link

Size Change: +70 B (+0.09%)

Total Size: 79.2 kB

Filename Size Change
compat/dist/compat.js 4.17 kB +17 B (+0.41%)
compat/dist/compat.mjs 4.1 kB +17 B (+0.42%)
compat/dist/compat.module.js 4.1 kB +17 B (+0.42%)
compat/dist/compat.umd.js 4.24 kB +19 B (+0.45%)
ℹ️ View Unchanged
Filename Size
debug/dist/debug.js 3.85 kB
debug/dist/debug.mjs 3.85 kB
debug/dist/debug.module.js 3.85 kB
debug/dist/debug.umd.js 3.93 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.mjs 274 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 346 B
dist/preact.js 4.78 kB
dist/preact.min.js 4.8 kB
dist/preact.min.module.js 4.8 kB
dist/preact.min.umd.js 4.83 kB
dist/preact.mjs 4.79 kB
dist/preact.module.js 4.79 kB
dist/preact.umd.js 4.83 kB
hooks/dist/hooks.js 1.54 kB
hooks/dist/hooks.mjs 1.57 kB
hooks/dist/hooks.module.js 1.57 kB
hooks/dist/hooks.umd.js 1.61 kB
jsx-runtime/dist/jsxRuntime.js 1.01 kB
jsx-runtime/dist/jsxRuntime.mjs 985 B
jsx-runtime/dist/jsxRuntime.module.js 985 B
jsx-runtime/dist/jsxRuntime.umd.js 1.08 kB
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.mjs 477 B
test-utils/dist/testUtils.module.js 477 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

@JoviDeCroock JoviDeCroock merged commit 58ad04e into v10.x Oct 24, 2025
14 checks passed
@JoviDeCroock JoviDeCroock deleted the fix-suspense-issue branch October 24, 2025 18:06
@JoviDeCroock JoviDeCroock mentioned this pull request Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants