Updates dangerouslySetInnerHTML type so future TS will accept Trusted…#4930
Merged
rschristian merged 1 commit intopreactjs:mainfrom Oct 23, 2025
Merged
Conversation
…HTML automatically
lukewarlow
force-pushed
the
update-dangerouslySetInnerHTML-types-for-tt
branch
from
2c22cb1 to
428bace
Compare
rschristian
approved these changes
Oct 23, 2025
Member
There was a problem hiding this comment.
Thanks!
Just to expound: parseFromString should take A TrustedHTML or string instance defining HTML to be parsed., though TS has yet to update lib/dom.d.ts to account for this. The method here should in theory be future proof though and collect the correct types for .innerHTML when/if TS makes them available.
Quite crafty
Contributor
Author
|
To provide a bit of extra detail we can't do something using innerHTML itself as that is currently a property but might become a getter setter pair and there's not a TS way to handle both those cases, nor does there seem to be a way to get the setter type, so this is a hack to get string | TrustedHTML in a workable way. |
This was referenced Oct 23, 2025
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…HTML automatically
Need to see if there's tests for this, and how to update them.