refactor (v10): Mirror non-JSX types to the 'preact' namespace#4904
Merged
rschristian merged 3 commits intov10.xfrom Aug 28, 2025
Merged
refactor (v10): Mirror non-JSX types to the 'preact' namespace#4904rschristian merged 3 commits intov10.xfrom
rschristian merged 3 commits intov10.xfrom
Conversation
📊 Tachometer Benchmark ResultsSummaryA summary of the benchmark results will show here once they finish. ResultsThe full results of your benchmarks will show here once they finish. |
rschristian
commented
Aug 27, 2025
JoviDeCroock
approved these changes
Aug 28, 2025
|
Hi |
Member
Author
|
Next time we cut a release, but when that happens is TBD. We don't schedule things. |
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4903
Non-breaking form of #4878
Duplicates our DOM types into a new
dom.d.tsfile (matching v11), exporting them under the Preact namespace (so you can doimport type { HTMLAttributes } from 'preact';), but maintains back-compat . This will allow library authors to switch to the Preact namespace and keep compatibility with v10 & v11 going forward.There's obviously some duplication here but unfortunately it's necessary -- turns out you can't label namespace aliases (i.e.,
export import ...) as deprecated. We need to keep the current types where they are so that users are warned they're using deprecated APIs.