Skip to content

Save bytes by inlining ref unmount checks#4896

Merged
JoviDeCroock merged 10 commits intomainfrom
golf-ref-unmount
Aug 22, 2025
Merged

Save bytes by inlining ref unmount checks#4896
JoviDeCroock merged 10 commits intomainfrom
golf-ref-unmount

Conversation

@JoviDeCroock
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 20, 2025

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +0% (-11.32ms - +3.65ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +2% (-0.07ms - +0.25ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +1% (-2.15ms - +0.50ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -2% - +1% (-0.28ms - +0.14ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -2% - +1% (-1.41ms - +0.75ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -5% - +4% (-0.09ms - +0.07ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +2% (-0.26ms - +0.53ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -5% - +1% (-1.43ms - +0.35ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -6% - +7% (-0.38ms - +0.43ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +1% (-0.01ms - +0.02ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -2% - +2% (-0.02ms - +0.02ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local980.88ms - 989.32ms-unsure 🔍
-1% - +0%
-11.32ms - +3.65ms
preact-main982.75ms - 995.12msunsure 🔍
-0% - +1%
-3.65ms - +11.32ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.03ms - 19.03ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-main19.03ms - 19.05msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.52ms - 16.57ms-unsure 🔍
-0% - +2%
-0.07ms - +0.25ms
preact-main16.29ms - 16.62msunsure 🔍
-2% - +0%
-0.25ms - +0.07ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.53ms - 1.54ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.53ms - 1.54msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local67.06ms - 68.89ms-unsure 🔍
-3% - +1%
-2.15ms - +0.50ms
preact-main67.84ms - 69.75msunsure 🔍
-1% - +3%
-0.50ms - +2.15ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local6.11ms - 6.67ms-unsure 🔍
-6% - +7%
-0.38ms - +0.43ms
preact-main6.08ms - 6.66msunsure 🔍
-7% - +6%
-0.43ms - +0.38ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.35ms - 16.64ms-unsure 🔍
-2% - +1%
-0.28ms - +0.14ms
preact-main16.42ms - 16.72msunsure 🔍
-1% - +2%
-0.14ms - +0.28ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.72ms - 3.72ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main3.72ms - 3.72msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #5098
  • Commit: ca2b22f

duration

VersionAvg timevs preact-localvs preact-main
preact-local61.59ms - 63.03ms-unsure 🔍
-2% - +1%
-1.41ms - +0.75ms
preact-main61.84ms - 63.44msunsure 🔍
-1% - +2%
-0.75ms - +1.41ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.99ms - 3.01ms-unsure 🔍
-0% - +1%
-0.01ms - +0.02ms
preact-main2.99ms - 3.01msunsure 🔍
-1% - +0%
-0.02ms - +0.01ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local24.76ms - 25.61ms-unsure 🔍
-1% - +3%
-0.20ms - +0.81ms
preact-main24.61ms - 25.15msunsure 🔍
-3% - +1%
-0.81ms - +0.20ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local32.48ms - 33.36ms-unsure 🔍
-0% - +3%
-0.07ms - +1.12ms
preact-main31.99ms - 32.80msunsure 🔍
-3% - +0%
-1.12ms - +0.07ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local32.27ms - 33.08ms-unsure 🔍
-0% - +3%
-0.06ms - +1.06ms
preact-main31.78ms - 32.56msunsure 🔍
-3% - +0%
-1.06ms - +0.06ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local25.30ms - 25.97ms-unsure 🔍
-3% - +1%
-0.78ms - +0.17ms
preact-main25.60ms - 26.28msunsure 🔍
-1% - +3%
-0.17ms - +0.78ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local23.96ms - 25.06ms-unsure 🔍
-4% - +2%
-1.05ms - +0.46ms
preact-main24.28ms - 25.33msunsure 🔍
-2% - +4%
-0.46ms - +1.05ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local21.26ms - 22.16ms-unsure 🔍
-3% - +3%
-0.73ms - +0.61ms
preact-main21.28ms - 22.26msunsure 🔍
-3% - +3%
-0.61ms - +0.73ms
-
text-update
  • Browser: chrome-headless
  • Sample size: 180
  • Built by: CI #5098
  • Commit: ca2b22f

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.84ms - 1.92ms-unsure 🔍
-5% - +4%
-0.09ms - +0.07ms
preact-main1.82ms - 1.97msunsure 🔍
-4% - +5%
-0.07ms - +0.09ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local0.98ms - 1.02ms-unsure 🔍
-2% - +2%
-0.02ms - +0.02ms
preact-main0.99ms - 1.02msunsure 🔍
-2% - +2%
-0.02ms - +0.02ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local31.53ms - 31.95ms-unsure 🔍
-1% - +2%
-0.26ms - +0.53ms
preact-main31.27ms - 31.94msunsure 🔍
-2% - +1%
-0.53ms - +0.26ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.25ms - 1.25ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main1.25ms - 1.25msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local30.47ms - 31.51ms-unsure 🔍
-5% - +1%
-1.43ms - +0.35ms
preact-main30.81ms - 32.25msunsure 🔍
-1% - +5%
-0.35ms - +1.43ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.93ms - 2.94ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-main2.93ms - 2.94msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms
-

tachometer-reporter-action v2 for CI

@github-actions
Copy link

github-actions bot commented Aug 20, 2025

Size Change: -83 B (-0.17%)

Total Size: 47.4 kB

Filename Size Change
dist/preact.js 4.66 kB -32 B (-0.68%)
dist/preact.mjs 4.69 kB -24 B (-0.51%)
dist/preact.umd.js 4.74 kB -27 B (-0.57%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 3.9 kB
compat/dist/compat.mjs 3.82 kB
compat/dist/compat.umd.js 3.95 kB
debug/dist/debug.js 3.9 kB
debug/dist/debug.mjs 3.9 kB
debug/dist/debug.umd.js 3.98 kB
devtools/dist/devtools.js 263 B
devtools/dist/devtools.mjs 273 B
devtools/dist/devtools.umd.js 348 B
hooks/dist/hooks.js 1.55 kB
hooks/dist/hooks.mjs 1.58 kB
hooks/dist/hooks.umd.js 1.62 kB
jsx-runtime/dist/jsxRuntime.js 892 B
jsx-runtime/dist/jsxRuntime.mjs 861 B
jsx-runtime/dist/jsxRuntime.umd.js 966 B
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.mjs 473 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

@coveralls
Copy link

coveralls commented Aug 20, 2025

Coverage Status

coverage: 99.536%. remained the same
when pulling ca2b22f on golf-ref-unmount
into 665126a on main.

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoviDeCroock JoviDeCroock merged commit 9c44db8 into main Aug 22, 2025
13 checks passed
@JoviDeCroock JoviDeCroock deleted the golf-ref-unmount branch August 22, 2025 06:00
@JoviDeCroock JoviDeCroock mentioned this pull request Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants