Skip to content

Remove rerendercount #4877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoviDeCroock merged 3 commits into from
Aug 5, 2025
Merged

Remove rerendercount #4877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ee411f
Remove rerendercount
JoviDeCroock Aug 5, 2025
caf4075
Save bytes
JoviDeCroock Aug 5, 2025
bbec579
Merge branch 'main' into remove-rerender-count
JoviDeCroock Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion mangle.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@
"$_unmount": "__u",
"$_owner": "__o",
"$_skipEffects": "__s",
"$_rerenderCount": "__r",
"$_forwarded": "__f",
"$_isSuspended": "__i",
"$_bits": "__g"
Expand Down
14 changes: 9 additions & 5 deletions src/component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,12 @@ let rerenderQueue = [];
* * [Callbacks synchronous and asynchronous](https://blog.ometer.com/2011/07/24/callbacks-synchronous-and-asynchronous/)
*/

let prevDebounce;
let prevDebounce,
rerenderCount = 0;

export function resetRenderCount() {
rerenderCount = 0;
}

/**
* Enqueue a rerender of a component
Expand All @@ -206,7 +211,7 @@ export function enqueueRender(c) {
(!(c._bits & COMPONENT_DIRTY) &&
(c._bits |= COMPONENT_DIRTY) &&
rerenderQueue.push(c) &&
!process._rerenderCount++) ||
!rerenderCount++) ||
prevDebounce != options.debounceRendering
) {
prevDebounce = options.debounceRendering;
Expand Down Expand Up @@ -245,7 +250,6 @@ function process() {
renderComponent(c);
}
}
process._rerenderCount = 0;
}

process._rerenderCount = 0;
rerenderCount = 0;
}
4 changes: 4 additions & 0 deletions src/diff/catch-error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { resetRenderCount } from '../component';
import {
NULL,
COMPONENT_DIRTY,
Expand Down Expand Up @@ -51,5 +52,8 @@ export function _catchError(error, vnode, oldVNode, errorInfo) {
}
}

// Reset rerender count to 0, so that the next render will not be skipped
// when we leverage prefresh
resetRenderCount();
throw error;
}
Loading