Skip to content

Conversation

@JoviDeCroock
Copy link
Member

I found a few things that seem unused, tests also keep passing and when I use it in a demo it looks all good

@JoviDeCroock JoviDeCroock marked this pull request as ready for review July 27, 2025 17:58
@github-actions
Copy link

github-actions bot commented Jul 27, 2025

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -0% - +1% (-0.84ms - +10.53ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.04ms - +0.04ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +2% (-1.46ms - +1.04ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +1% (-0.06ms - +0.13ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -2% - +1% (-1.02ms - +0.78ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -10% - +2% (-0.22ms - +0.04ms)
    preact-local vs preact-main
  • todo: faster ✔ 0% - 1% (0.06ms - 0.38ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -5% - +4% (-1.42ms - +1.26ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +11% (-0.07ms - +0.62ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +1% (-0.02ms - +0.03ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -0% - +4% (-0.00ms - +0.04ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local972.97ms - 982.70ms-unsure 🔍
-0% - +1%
-0.84ms - +10.53ms
preact-main970.04ms - 975.94msunsure 🔍
-1% - +0%
-10.53ms - +0.84ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.18ms - 19.19ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main19.19ms - 19.19msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.50ms - 16.55ms-unsure 🔍
-0% - +0%
-0.04ms - +0.04ms
preact-main16.50ms - 16.55msunsure 🔍
-0% - +0%
-0.04ms - +0.04ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.54ms - 1.54ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.54ms - 1.54msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local66.84ms - 68.49ms-unsure 🔍
-2% - +2%
-1.46ms - +1.04ms
preact-main66.94ms - 68.82msunsure 🔍
-2% - +2%
-1.04ms - +1.46ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local5.82ms - 6.28ms-unsure 🔍
-1% - +11%
-0.07ms - +0.62ms
preact-main5.51ms - 6.03msunsure 🔍
-10% - +1%
-0.62ms - +0.07ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.53ms - 16.57ms-unsure 🔍
-0% - +1%
-0.06ms - +0.13ms
preact-main16.43ms - 16.61msunsure 🔍
-1% - +0%
-0.13ms - +0.06ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.71ms - 3.71ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main3.71ms - 3.71msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms
-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #4919
  • Commit: 4632097

duration

VersionAvg timevs preact-localvs preact-main
preact-local60.76ms - 62.11ms-unsure 🔍
-2% - +1%
-1.02ms - +0.78ms
preact-main60.96ms - 62.16msunsure 🔍
-1% - +2%
-0.78ms - +1.02ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.10ms - 3.13ms-unsure 🔍
-1% - +1%
-0.02ms - +0.03ms
preact-main3.09ms - 3.12msunsure 🔍
-1% - +1%
-0.03ms - +0.02ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local24.76ms - 25.71ms-unsure 🔍
-1% - +4%
-0.19ms - +1.01ms
preact-main24.47ms - 25.19msunsure 🔍
-4% - +1%
-1.01ms - +0.19ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local32.67ms - 33.72ms-unsure 🔍
-0% - +5%
-0.00ms - +1.54ms
preact-main31.86ms - 32.99msunsure 🔍
-5% - -0%
-1.54ms - +0.00ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local28.56ms - 29.50ms-unsure 🔍
-2% - +3%
-0.61ms - +0.77ms
preact-main28.44ms - 29.46msunsure 🔍
-3% - +2%
-0.77ms - +0.61ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local26.50ms - 27.33ms-unsure 🔍
-1% - +3%
-0.34ms - +0.79ms
preact-main26.31ms - 27.08msunsure 🔍
-3% - +1%
-0.79ms - +0.34ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local21.69ms - 22.77ms-unsure 🔍
-5% - +2%
-1.06ms - +0.43ms
preact-main22.03ms - 23.06msunsure 🔍
-2% - +5%
-0.43ms - +1.06ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local20.88ms - 21.66ms-unsure 🔍
-4% - +2%
-0.77ms - +0.37ms
preact-main21.05ms - 21.89msunsure 🔍
-2% - +4%
-0.37ms - +0.77ms
-
text-update
  • Browser: chrome-headless
  • Sample size: 240
  • Built by: CI #4919
  • Commit: 4632097

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.88ms - 2.04ms-unsure 🔍
-10% - +2%
-0.22ms - +0.04ms
preact-main1.95ms - 2.15msunsure 🔍
-2% - +11%
-0.04ms - +0.22ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local0.98ms - 1.02ms-unsure 🔍
-0% - +4%
-0.00ms - +0.04ms
preact-main0.97ms - 0.99msunsure 🔍
-4% - +0%
-0.04ms - +0.00ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local32.25ms - 32.47ms-faster ✔
0% - 1%
0.06ms - 0.38ms
preact-main32.47ms - 32.71msslower ❌
0% - 1%
0.06ms - 0.38ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.24ms - 1.24ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.24ms - 1.24msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local30.45ms - 32.18ms-unsure 🔍
-5% - +4%
-1.42ms - +1.26ms
preact-main30.37ms - 32.42msunsure 🔍
-4% - +5%
-1.26ms - +1.42ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.94ms - 2.95ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main2.94ms - 2.95msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms
-

tachometer-reporter-action v2 for CI

@github-actions
Copy link

Size Change: -79 B (-0.17%)

Total Size: 47.2 kB

Filename Size Change
compat/dist/compat.js 3.91 kB -25 B (-0.64%)
compat/dist/compat.mjs 3.82 kB -27 B (-0.7%)
compat/dist/compat.umd.js 3.96 kB -27 B (-0.68%)
ℹ️ View Unchanged
Filename Size
debug/dist/debug.js 3.88 kB
debug/dist/debug.mjs 3.89 kB
debug/dist/debug.umd.js 3.97 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.mjs 271 B
devtools/dist/devtools.umd.js 346 B
dist/preact.js 4.62 kB
dist/preact.mjs 4.63 kB
dist/preact.umd.js 4.69 kB
hooks/dist/hooks.js 1.55 kB
hooks/dist/hooks.mjs 1.58 kB
hooks/dist/hooks.umd.js 1.62 kB
jsx-runtime/dist/jsxRuntime.js 892 B
jsx-runtime/dist/jsxRuntime.mjs 861 B
jsx-runtime/dist/jsxRuntime.umd.js 966 B
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.mjs 473 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

@coveralls
Copy link

Coverage Status

coverage: 99.533% (-0.004%) from 99.537%
when pulling 4632097 on gold-suspense
into 13a5ce7 on main.

Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice finds!

@JoviDeCroock JoviDeCroock merged commit 6734ff2 into main Jul 28, 2025
13 checks passed
@JoviDeCroock JoviDeCroock deleted the gold-suspense branch July 28, 2025 06:27
@JoviDeCroock JoviDeCroock mentioned this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants