Skip to content

Conversation

@rschristian
Copy link
Member

Links to the new shim package rather than the gist.

A comment on the gist stated they were seeing the comment on the deprecated overload even when not using the third parameter, and whilst I can't reproduce (it only pops up when I actually use the third param in my editor), I figured expanding the comment to explicitly mentioning replaceNode would be a good idea.

@github-actions
Copy link

📊 Tachometer Benchmark Results

Summary

A summary of the benchmark results will show here once they finish.

Results

The full results of your benchmarks will show here once they finish.

tachometer-reporter-action v2 for CI

@rschristian
Copy link
Member Author

rschristian commented Jul 16, 2025

Hrm, not related but it seems the PR reporter is now comparing the branch against main, rather than the target. Will look into it

Edit: Oh, it might be that the PR reporter action is out of date? Still weird though as the PR base is set to main, which doesn't make sense to me. Will make a separate PR to at least align v10.x w/ main there

@rschristian rschristian merged commit a9b12d9 into v10.x Jul 17, 2025
6 checks passed
@rschristian rschristian deleted the chore/replaceNode-deprecation-comment branch July 17, 2025 06:51
@JoviDeCroock JoviDeCroock mentioned this pull request Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants