Fix empty children #4822
Closed
Fix empty children #4822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Tachometer Benchmark ResultsSummaryA summary of the benchmark results will show here once they finish. ResultsThe full results of your benchmarks will show here once they finish. |
|
Size Change: +16 B (+0.02%) Total Size: 78.7 kB
ℹ️ View Unchanged
|
JoviDeCroock
force-pushed
the
fix-empty-children
branch
from
e447235 to
d55f62d
Compare
Member
Author
|
I am well and thoroughly confused by our tests erroring out right now 😂 EDIT: ah a rebase was all it took |
rschristian
reviewed
Jun 30, 2025
| } else { | ||
| newVNode._dom = oldVNode._dom; | ||
| newVNode._children = oldVNode._children; | ||
| newVNode._children = oldVNode._children || []; |
Member
There was a problem hiding this comment.
Suggested change
| newVNode._children = oldVNode._children || []; | |
| newVNode._children = oldVNode._children || EMPTY_ARR; |
Will need to add it as an import tho, wish GH allowed users to suggest outside the diff.
Weird that the CI is failing. Edit: Ah, looks like we'll need to manually upload something to get the 10.x line working again.
Member
There was a problem hiding this comment.
Would add a small comment here too on why we set it to a default value (e.g. point to prefresh issue)
rschristian
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preactjs/prefresh#568 the point was rightfully made that we lose our assurance that
_childrenis always an array. When a component throws on first-render we risk setting anundefinedvalue and then re-using it for recovered renders.I haven't found a way to actually make this occur in our test suite yet though