perf: reduce some repeated logic (#4814) #4821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* perf: use createElement when cloning To avoid duplicating logic, we can use `createElement` with pre-populated props. * chore: reduce search logic * perf: reuse matched flag * chore: put the function inline again * perf: simplify to a ternary * perf: revert clone function --------- Co-authored-by: Jovi De Croock <[email protected]>
📊 Tachometer Benchmark ResultsSummaryA summary of the benchmark results will show here once they finish. ResultsThe full results of your benchmarks will show here once they finish. |
|
Size Change: -106 B (-0.13%) Total Size: 78.7 kB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid duplicating logic, we can use
createElementwith pre-populated props.chore: reduce search logic
perf: reuse matched flag
chore: put the function inline again
perf: simplify to a ternary
perf: revert clone function