Skip to content

Only one toLowerCase invoke #4764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoviDeCroock merged 2 commits into from
May 16, 2025
Merged

Only one toLowerCase invoke #4764

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
373d55a
Only one toLowerCase invoke
JoviDeCroock May 14, 2025
d20930e
Merge branch 'main' into try-perf-improvement-props
JoviDeCroock May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/diff/props.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,14 +67,11 @@ export function setProperty(dom, name, value, oldValue, namespace) {
// Benchmark for comparison: https://esbench.com/bench/574c954bdb965b9a00965ac6
else if (name[0] == 'o' && name[1] == 'n') {
useCapture = name != (name = name.replace(CAPTURE_REGEX, '$1'));
const lowerCaseName = name.toLowerCase();

// Infer correct casing for DOM built-in events:
if (
name.toLowerCase() in dom ||
name == 'onFocusOut' ||
name == 'onFocusIn'
)
name = name.toLowerCase().slice(2);
if (lowerCaseName in dom || name == 'onFocusOut' || name == 'onFocusIn')
name = lowerCaseName.slice(2);
else name = name.slice(2);

if (!dom._listeners) dom._listeners = {};
Expand Down
Loading