Skip to content

Conversation

@JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented May 12, 2025

This golfs some bytes from the portal implementation as well as changing the _mask thing. I ended up feeling a bit uncomfortable while thinking about testing solutions and this being on _children Shook it off as this is not a VNode but a FAUX dom node

@github-actions
Copy link

github-actions bot commented May 12, 2025

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +0% (-11.34ms - +2.32ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.01ms - +0.05ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +2% (-1.22ms - +1.46ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -3% - +2% (-0.45ms - +0.37ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -3% - +1% (-1.68ms - +0.54ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -7% - +1% (-0.15ms - +0.02ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +1% (-0.22ms - +0.38ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -3% - +4% (-0.81ms - +1.05ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -4% - +5% (-0.35ms - +0.36ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +1% (-0.01ms - +0.02ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -3% - +1% (-0.03ms - +0.02ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +1% (-0.01ms - +0.02ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local981.24ms - 989.83ms-unsure 🔍
-1% - +0%
-11.34ms - +2.32ms
preact-main984.74ms - 995.35msunsure 🔍
-0% - +1%
-2.32ms - +11.34ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.18ms - 19.18ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-main19.18ms - 19.19msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.55ms - 16.59ms-unsure 🔍
-0% - +0%
-0.01ms - +0.05ms
preact-main16.53ms - 16.57msunsure 🔍
-0% - +0%
-0.05ms - +0.01ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.54ms - 1.54ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main1.54ms - 1.54msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local71.17ms - 72.97ms-unsure 🔍
-2% - +2%
-1.22ms - +1.46ms
preact-main70.95ms - 72.94msunsure 🔍
-2% - +2%
-1.46ms - +1.22ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local7.53ms - 8.04ms-unsure 🔍
-4% - +5%
-0.35ms - +0.36ms
preact-main7.54ms - 8.02msunsure 🔍
-5% - +4%
-0.36ms - +0.35ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local15.97ms - 16.55ms-unsure 🔍
-3% - +2%
-0.45ms - +0.37ms
preact-main16.01ms - 16.59msunsure 🔍
-2% - +3%
-0.37ms - +0.45ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.78ms - 3.78ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main3.77ms - 3.78msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms
-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #4692
  • Commit: c2a6294

duration

VersionAvg timevs preact-localvs preact-main
preact-local64.30ms - 65.77ms-unsure 🔍
-3% - +1%
-1.68ms - +0.54ms
preact-main64.78ms - 66.44msunsure 🔍
-1% - +3%
-0.54ms - +1.68ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.14ms - 3.16ms-unsure 🔍
-0% - +1%
-0.01ms - +0.02ms
preact-main3.13ms - 3.16msunsure 🔍
-1% - +0%
-0.02ms - +0.01ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local26.35ms - 27.18ms-unsure 🔍
-1% - +3%
-0.32ms - +0.75ms
preact-main26.21ms - 26.88msunsure 🔍
-3% - +1%
-0.75ms - +0.32ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local33.90ms - 35.30ms-unsure 🔍
-3% - +3%
-0.99ms - +0.94ms
preact-main33.96ms - 35.29msunsure 🔍
-3% - +3%
-0.94ms - +0.99ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local30.25ms - 31.38ms-slower ❌
0% - 5%
0.10ms - 1.60ms
preact-main29.46ms - 30.46msfaster ✔
0% - 5%
0.10ms - 1.60ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local27.77ms - 28.91ms-unsure 🔍
-3% - +2%
-0.89ms - +0.60ms
preact-main28.00ms - 28.97msunsure 🔍
-2% - +3%
-0.60ms - +0.89ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local24.99ms - 26.40ms-unsure 🔍
-4% - +4%
-1.02ms - +0.94ms
preact-main25.05ms - 26.41msunsure 🔍
-4% - +4%
-0.94ms - +1.02ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local21.67ms - 22.38ms-unsure 🔍
-5% - +0%
-1.06ms - +0.10ms
preact-main22.04ms - 22.97msunsure 🔍
-0% - +5%
-0.10ms - +1.06ms
-
text-update
  • Browser: chrome-headless
  • Sample size: 230
  • Built by: CI #4692
  • Commit: c2a6294

duration

VersionAvg timevs preact-localvs preact-main
preact-local2.00ms - 2.12ms-unsure 🔍
-7% - +1%
-0.15ms - +0.02ms
preact-main2.06ms - 2.19msunsure 🔍
-1% - +7%
-0.02ms - +0.15ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.15ms - 1.19ms-unsure 🔍
-3% - +1%
-0.03ms - +0.02ms
preact-main1.16ms - 1.20msunsure 🔍
-2% - +3%
-0.02ms - +0.03ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local34.99ms - 35.41ms-unsure 🔍
-1% - +1%
-0.22ms - +0.38ms
preact-main34.90ms - 35.33msunsure 🔍
-1% - +1%
-0.38ms - +0.22ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.24ms - 1.26ms-unsure 🔍
-1% - +1%
-0.01ms - +0.02ms
preact-main1.23ms - 1.25msunsure 🔍
-1% - +1%
-0.02ms - +0.01ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local29.40ms - 30.85ms-unsure 🔍
-3% - +4%
-0.81ms - +1.05ms
preact-main29.42ms - 30.59msunsure 🔍
-3% - +3%
-1.05ms - +0.81ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.95ms - 2.95ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main2.94ms - 2.95msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms
-

tachometer-reporter-action v2 for CI

@github-actions
Copy link

github-actions bot commented May 12, 2025

Size Change: -38 B (-0.05%)

Total Size: 78.6 kB

Filename Size Change
compat/dist/compat.js 4.15 kB -8 B (-0.19%)
compat/dist/compat.mjs 4.08 kB -8 B (-0.2%)
compat/dist/compat.module.js 4.08 kB -8 B (-0.2%)
compat/dist/compat.umd.js 4.21 kB -14 B (-0.33%)
ℹ️ View Unchanged
Filename Size
debug/dist/debug.js 3.82 kB
debug/dist/debug.mjs 3.82 kB
debug/dist/debug.module.js 3.82 kB
debug/dist/debug.umd.js 3.9 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.mjs 274 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 346 B
dist/preact.js 4.75 kB
dist/preact.min.js 4.77 kB
dist/preact.min.module.js 4.77 kB
dist/preact.min.umd.js 4.8 kB
dist/preact.mjs 4.76 kB
dist/preact.module.js 4.76 kB
dist/preact.umd.js 4.8 kB
hooks/dist/hooks.js 1.54 kB
hooks/dist/hooks.mjs 1.57 kB
hooks/dist/hooks.module.js 1.57 kB
hooks/dist/hooks.umd.js 1.61 kB
jsx-runtime/dist/jsxRuntime.js 978 B
jsx-runtime/dist/jsxRuntime.mjs 952 B
jsx-runtime/dist/jsxRuntime.module.js 952 B
jsx-runtime/dist/jsxRuntime.umd.js 1.05 kB
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.mjs 477 B
test-utils/dist/testUtils.module.js 477 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

@JoviDeCroock JoviDeCroock changed the title Golf some poral childs Golf some portal bytes May 12, 2025
@JoviDeCroock JoviDeCroock merged commit 44c8f89 into main May 16, 2025
12 checks passed
@JoviDeCroock JoviDeCroock deleted the golf-bytes branch May 16, 2025 04:20
@JoviDeCroock JoviDeCroock mentioned this pull request May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants