Skip to content

Ensure useId works in portals#4752

Merged
JoviDeCroock merged 3 commits intomainfrom
ensure-use-id-works-in-portals
May 4, 2025
Merged

Ensure useId works in portals#4752
JoviDeCroock merged 3 commits intomainfrom
ensure-use-id-works-in-portals

Conversation

@JoviDeCroock
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented May 4, 2025

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +0% (-9.22ms - +4.29ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -1% - +2% (-0.14ms - +0.36ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +2% (-0.53ms - +1.61ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -1% - +2% (-0.09ms - +0.29ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +2% (-0.89ms - +1.19ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -5% - +2% (-0.12ms - +0.04ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +2% (-0.45ms - +0.50ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -4% - +2% (-1.32ms - +0.69ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -2% - +1% (-0.03ms - +0.01ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -9% - +4% (-0.61ms - +0.29ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +1% (-0.01ms - +0.02ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -5% - +0% (-0.06ms - +0.01ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -2% - +0% (-0.03ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local1000.98ms - 1007.85ms-unsure 🔍
-1% - +0%
-9.22ms - +4.29ms
preact-main1001.06ms - 1012.71msunsure 🔍
-0% - +1%
-4.29ms - +9.22ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.18ms - 19.18ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main19.18ms - 19.18msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.42ms - 16.91ms-unsure 🔍
-1% - +2%
-0.14ms - +0.36ms
preact-main16.53ms - 16.58msunsure 🔍
-2% - +1%
-0.36ms - +0.14ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.54ms - 1.57ms-unsure 🔍
-2% - +1%
-0.03ms - +0.01ms
preact-main1.55ms - 1.58msunsure 🔍
-1% - +2%
-0.01ms - +0.03ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local71.47ms - 73.30ms-unsure 🔍
-1% - +2%
-0.53ms - +1.61ms
preact-main71.30ms - 72.39msunsure 🔍
-2% - +1%
-1.61ms - +0.53ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local6.39ms - 7.04ms-unsure 🔍
-9% - +4%
-0.61ms - +0.29ms
preact-main6.56ms - 7.18msunsure 🔍
-4% - +9%
-0.29ms - +0.61ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.40ms - 16.62ms-unsure 🔍
-1% - +2%
-0.09ms - +0.29ms
preact-main16.25ms - 16.56msunsure 🔍
-2% - +1%
-0.29ms - +0.09ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.77ms - 3.80ms-unsure 🔍
-0% - +1%
-0.01ms - +0.02ms
preact-main3.77ms - 3.79msunsure 🔍
-1% - +0%
-0.02ms - +0.01ms
-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #4674
  • Commit: 329eb6b

duration

VersionAvg timevs preact-localvs preact-main
preact-local64.50ms - 65.81ms-unsure 🔍
-1% - +2%
-0.89ms - +1.19ms
preact-main64.19ms - 65.81msunsure 🔍
-2% - +1%
-1.19ms - +0.89ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.98ms - 3.00ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main2.99ms - 2.99msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local25.77ms - 26.51ms-unsure 🔍
-2% - +2%
-0.58ms - +0.43ms
preact-main25.87ms - 26.56msunsure 🔍
-2% - +2%
-0.43ms - +0.58ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local32.66ms - 33.86ms-unsure 🔍
-3% - +2%
-0.85ms - +0.81ms
preact-main32.70ms - 33.86msunsure 🔍
-2% - +3%
-0.81ms - +0.85ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local28.01ms - 29.01ms-unsure 🔍
-2% - +3%
-0.66ms - +0.73ms
preact-main27.98ms - 28.97msunsure 🔍
-3% - +2%
-0.73ms - +0.66ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local24.20ms - 25.28ms-unsure 🔍
-5% - +1%
-1.21ms - +0.37ms
preact-main24.59ms - 25.73msunsure 🔍
-2% - +5%
-0.37ms - +1.21ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local24.26ms - 25.41ms-unsure 🔍
-5% - +2%
-1.23ms - +0.62ms
preact-main24.41ms - 25.86msunsure 🔍
-3% - +5%
-0.62ms - +1.23ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local20.72ms - 21.58ms-unsure 🔍
-1% - +5%
-0.27ms - +1.00ms
preact-main20.32ms - 21.25msunsure 🔍
-5% - +1%
-1.00ms - +0.27ms
-
text-update
  • Browser: chrome-headless
  • Sample size: 230
  • Built by: CI #4674
  • Commit: 329eb6b

duration

VersionAvg timevs preact-localvs preact-main
preact-local2.10ms - 2.20ms-unsure 🔍
-5% - +2%
-0.12ms - +0.04ms
preact-main2.13ms - 2.25msunsure 🔍
-2% - +5%
-0.04ms - +0.12ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.17ms - 1.22ms-unsure 🔍
-5% - +0%
-0.06ms - +0.01ms
preact-main1.20ms - 1.25msunsure 🔍
-1% - +5%
-0.01ms - +0.06ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local33.14ms - 33.79ms-unsure 🔍
-1% - +2%
-0.45ms - +0.50ms
preact-main33.09ms - 33.78msunsure 🔍
-2% - +1%
-0.50ms - +0.45ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.24ms - 1.25ms-unsure 🔍
-2% - +0%
-0.03ms - +0.00ms
preact-main1.24ms - 1.28msunsure 🔍
-0% - +2%
-0.00ms - +0.03ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local30.37ms - 31.79ms-unsure 🔍
-4% - +2%
-1.32ms - +0.69ms
preact-main30.68ms - 32.11msunsure 🔍
-2% - +4%
-0.69ms - +1.32ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.95ms - 2.96ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-main2.96ms - 2.97msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms
-

tachometer-reporter-action v2 for CI

@github-actions
Copy link

github-actions bot commented May 4, 2025

Size Change: +142 B (+0.18%)

Total Size: 78.7 kB

Filename Size Change
compat/dist/compat.js 4.16 kB +36 B (+0.87%)
compat/dist/compat.mjs 4.08 kB +35 B (+0.86%)
compat/dist/compat.module.js 4.08 kB +35 B (+0.86%)
compat/dist/compat.umd.js 4.23 kB +36 B (+0.86%)
ℹ️ View Unchanged
Filename Size
debug/dist/debug.js 3.82 kB
debug/dist/debug.mjs 3.82 kB
debug/dist/debug.module.js 3.82 kB
debug/dist/debug.umd.js 3.9 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.mjs 274 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 346 B
dist/preact.js 4.75 kB
dist/preact.min.js 4.77 kB
dist/preact.min.module.js 4.77 kB
dist/preact.min.umd.js 4.8 kB
dist/preact.mjs 4.76 kB
dist/preact.module.js 4.76 kB
dist/preact.umd.js 4.8 kB
hooks/dist/hooks.js 1.54 kB
hooks/dist/hooks.mjs 1.57 kB
hooks/dist/hooks.module.js 1.57 kB
hooks/dist/hooks.umd.js 1.61 kB
jsx-runtime/dist/jsxRuntime.js 978 B
jsx-runtime/dist/jsxRuntime.mjs 952 B
jsx-runtime/dist/jsxRuntime.module.js 952 B
jsx-runtime/dist/jsxRuntime.umd.js 1.05 kB
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.mjs 477 B
test-utils/dist/testUtils.module.js 477 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great catch!

@JoviDeCroock JoviDeCroock merged commit 8e05a6f into main May 4, 2025
12 checks passed
@JoviDeCroock JoviDeCroock deleted the ensure-use-id-works-in-portals branch May 4, 2025 09:40
@JoviDeCroock JoviDeCroock mentioned this pull request May 5, 2025
@preactjs preactjs deleted a comment from BPScott May 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments