Skip to content

Reduce raf timeout to 35ms #4750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoviDeCroock merged 3 commits into from
May 17, 2025
Merged

Reduce raf timeout to 35ms #4750

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c8aac02
Reduce raf timeout to 35ms
JoviDeCroock Apr 27, 2025
4251455
Merge branch 'main' into reduce-raf-timeout-35ms
JoviDeCroock May 5, 2025
a2e7ec9
Merge branch 'main' into reduce-raf-timeout-35ms
JoviDeCroock May 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion hooks/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,10 @@ let oldCommit = options._commit;
let oldBeforeUnmount = options.unmount;
let oldRoot = options._root;

const RAF_TIMEOUT = 100;
// We take the minimum timeout for requestAnimationFrame to ensure that
// the callback is invoked after the next frame. 35ms is based on a 30hz
// refresh rate, which is the minimum rate for a smooth user experience.
const RAF_TIMEOUT = 35;
let prevRaf;

/** @type {(vnode: import('./internal').VNode) => void} */
Expand Down
Loading