Bugfix: Change HTMLMediaElement.controlsList type to string (DOMTokenList)#4744
Merged
rschristian merged 1 commit intopreactjs:mainfrom Apr 8, 2025
Merged
Bugfix: Change HTMLMediaElement.controlsList type to string (DOMTokenList)#4744rschristian merged 1 commit intopreactjs:mainfrom
HTMLMediaElement.controlsList type to string (DOMTokenList)#4744rschristian merged 1 commit intopreactjs:mainfrom
Conversation
HTMLMediaElement.controlslist type to string (DOMTokenList)HTMLMediaElement.controlsList type to string (DOMTokenList)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partially reverts #4705 which incorrectly narrowed down types for HTMLMediaElement.controlsList attribute.
The
controlsListattribute is aDOMTokenList(space separated list of recommended keywords, like Element.classList), not a single keyword:Reproduction:
References: