Avoid cloning reused nodes

[JoviDeCroock]

Fixes preactjs/signals#659

Avoid cloning nodes that we are re-using, the diffChildren algorithm will already ensure we clone these and we do it in a more correct way there https://github.com/preactjs/preact/blob/main/src/diff/children.js#L210. In signals we rely on this cloning with https://github.com/preactjs/signals/blob/main/packages/preact/src/index.ts#L164

I have yet to test this fix, but this looks like the right approach 😅

EDIT: does seem to work https://stackblitz.com/edit/vitejs-vite-jdff8rn3?file=src%2Fsignals.js,src%2Fapp.tsx,src%2Fpreact.js,src%2Fhooks.js,src%2Fmain.tsx

[github-actions]

📊 Tachometer Benchmark Results

Summary

duration

• create10k: unsure 🔍 -0% - +1% (-2.42ms - +11.57ms)
  ^{preact-local vs preact-main}
• filter-list: unsure 🔍 -1% - +1% (-0.21ms - +0.11ms)
  ^{preact-local vs preact-main}
• hydrate1k: unsure 🔍 -1% - +1% (-1.17ms - +1.00ms)
  ^{preact-local vs preact-main}
• many-updates: unsure 🔍 -1% - +1% (-0.15ms - +0.12ms)
  ^{preact-local vs preact-main}
• replace1k: unsure 🔍 -0% - +2% (-0.10ms - +1.46ms)
  ^{preact-local vs preact-main}
• text-update: unsure 🔍 -2% - +5% (-0.04ms - +0.11ms)
  ^{preact-local vs preact-main}
• todo: faster ✔ 0% - 2% (0.12ms - 0.59ms)
  ^{preact-local vs preact-main}
• update10th1k: unsure 🔍 -4% - +3% (-1.39ms - +1.13ms)
  ^{preact-local vs preact-main}

usedJSHeapSize

• create10k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
  ^{preact-local vs preact-main}
• filter-list: unsure 🔍 -2% - +2% (-0.03ms - +0.03ms)
  ^{preact-local vs preact-main}
• hydrate1k: faster ✔ 2% - 11% (0.13ms - 0.94ms)
  ^{preact-local vs preact-main}
• many-updates: unsure 🔍 -1% - +1% (-0.02ms - +0.05ms)
  ^{preact-local vs preact-main}
• replace1k: unsure 🔍 -1% - +0% (-0.04ms - +0.00ms)
  ^{preact-local vs preact-main}
• text-update: unsure 🔍 -5% - +1% (-0.06ms - +0.02ms)
  ^{preact-local vs preact-main}
• todo: unsure 🔍 -1% - +2% (-0.01ms - +0.02ms)
  ^{preact-local vs preact-main}
• update10th1k: unsure 🔍 -1% - +1% (-0.03ms - +0.02ms)
  ^{preact-local vs preact-main}

Results

create10k

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4627

• Commit: e6a489d

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	938.03ms - 949.68ms	-	unsure 🔍 -0% - +1% -2.42ms - +11.57ms
preact-main	935.40ms - 943.15ms	unsure 🔍 -1% - +0% -11.57ms - +2.42ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	19.19ms - 19.20ms	-	unsure 🔍 -0% - +0% -0.01ms - +0.01ms
preact-main	19.19ms - 19.20ms	unsure 🔍 -0% - +0% -0.01ms - +0.01ms	-

filter-list

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4627

• Commit: e6a489d

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.55ms - 16.61ms	-	unsure 🔍 -1% - +1% -0.21ms - +0.11ms
preact-main	16.48ms - 16.78ms	unsure 🔍 -1% - +1% -0.11ms - +0.21ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.56ms - 1.60ms	-	unsure 🔍 -2% - +2% -0.03ms - +0.03ms
preact-main	1.56ms - 1.60ms	unsure 🔍 -2% - +2% -0.03ms - +0.03ms	-

hydrate1k

• Browser: chrome-headless
• Sample size: 90
• Built by: CI #4627

• Commit: e6a489d

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	77.78ms - 79.37ms	-	unsure 🔍 -1% - +1% -1.17ms - +1.00ms
preact-main	77.91ms - 79.39ms	unsure 🔍 -1% - +1% -1.00ms - +1.17ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	7.92ms - 8.50ms	-	faster ✔ 2% - 11% 0.13ms - 0.94ms
preact-main	8.46ms - 9.03ms	slower ❌ 1% - 12% 0.13ms - 0.94ms	-

many-updates

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4627

• Commit: e6a489d

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.40ms - 16.63ms	-	unsure 🔍 -1% - +1% -0.15ms - +0.12ms
preact-main	16.46ms - 16.60ms	unsure 🔍 -1% - +1% -0.12ms - +0.15ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.82ms - 3.86ms	-	unsure 🔍 -1% - +1% -0.02ms - +0.05ms
preact-main	3.80ms - 3.85ms	unsure 🔍 -1% - +1% -0.05ms - +0.02ms	-

replace1k

• Browser: chrome-headless
• Sample size: 90
• Built by: CI #4627

• Commit: e6a489d

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	74.02ms - 75.08ms	-	unsure 🔍 -0% - +2% -0.10ms - +1.46ms
preact-main	73.30ms - 74.44ms	unsure 🔍 -2% - +0% -1.46ms - +0.10ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.99ms - 3.01ms	-	unsure 🔍 -1% - +0% -0.04ms - +0.00ms
preact-main	3.00ms - 3.04ms	unsure 🔍 -0% - +1% -0.00ms - +0.04ms	-

run-warmup-0

Version	Avg time	vs preact-local	vs preact-main
preact-local	31.01ms - 31.66ms	-	unsure 🔍 -2% - +1% -0.79ms - +0.24ms
preact-main	31.21ms - 32.01ms	unsure 🔍 -1% - +3% -0.24ms - +0.79ms	-

run-warmup-1

Version	Avg time	vs preact-local	vs preact-main
preact-local	35.25ms - 36.32ms	-	faster ✔ 0% - 4% 0.10ms - 1.58ms
preact-main	36.12ms - 37.14ms	slower ❌ 0% - 4% 0.10ms - 1.58ms	-

run-warmup-2

Version	Avg time	vs preact-local	vs preact-main
preact-local	27.36ms - 27.97ms	-	unsure 🔍 -0% - +2% -0.09ms - +0.63ms
preact-main	27.20ms - 27.59ms	unsure 🔍 -2% - +0% -0.63ms - +0.09ms	-

run-warmup-3

Version	Avg time	vs preact-local	vs preact-main
preact-local	27.99ms - 28.69ms	-	unsure 🔍 -2% - +2% -0.51ms - +0.53ms
preact-main	27.94ms - 28.72ms	unsure 🔍 -2% - +2% -0.53ms - +0.51ms	-

run-warmup-4

Version	Avg time	vs preact-local	vs preact-main
preact-local	28.16ms - 28.81ms	-	unsure 🔍 -0% - +3% -0.11ms - +0.89ms
preact-main	27.71ms - 28.47ms	unsure 🔍 -3% - +0% -0.89ms - +0.11ms	-

run-final

Version	Avg time	vs preact-local	vs preact-main
preact-local	21.30ms - 21.68ms	-	unsure 🔍 -2% - +1% -0.34ms - +0.27ms
preact-main	21.28ms - 21.76ms	unsure 🔍 -1% - +2% -0.27ms - +0.34ms	-

text-update

• Browser: chrome-headless
• Sample size: 230
• Built by: CI #4627

• Commit: e6a489d

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.08ms - 2.21ms	-	unsure 🔍 -2% - +5% -0.04ms - +0.11ms
preact-main	2.07ms - 2.16ms	unsure 🔍 -5% - +2% -0.11ms - +0.04ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.17ms - 1.22ms	-	unsure 🔍 -5% - +1% -0.06ms - +0.02ms
preact-main	1.19ms - 1.25ms	unsure 🔍 -1% - +5% -0.02ms - +0.06ms	-

todo

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4627

• Commit: e6a489d

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	34.39ms - 34.69ms	-	faster ✔ 0% - 2% 0.12ms - 0.59ms
preact-main	34.71ms - 35.07ms	slower ❌ 0% - 2% 0.12ms - 0.59ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.24ms - 1.26ms	-	unsure 🔍 -1% - +2% -0.01ms - +0.02ms
preact-main	1.23ms - 1.26ms	unsure 🔍 -2% - +1% -0.02ms - +0.01ms	-

update10th1k

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4627

• Commit: e6a489d

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	31.13ms - 32.97ms	-	unsure 🔍 -4% - +3% -1.39ms - +1.13ms
preact-main	31.33ms - 33.05ms	unsure 🔍 -4% - +4% -1.13ms - +1.39ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.96ms - 2.98ms	-	unsure 🔍 -1% - +1% -0.03ms - +0.02ms
preact-main	2.96ms - 2.99ms	unsure 🔍 -1% - +1% -0.02ms - +0.03ms	-

_{tachometer-reporter-action v2 for CI}

[github-actions]

Size Change: +44 B (+0.06%)

Total Size: 78.5 kB

Filename	Size	Change
dist/preact.js	4.75 kB	+6 B (+0.13%)
dist/preact.min.js	4.77 kB	+7 B (+0.15%)
dist/preact.min.module.js	4.77 kB	+6 B (+0.13%)
dist/preact.min.umd.js	4.8 kB	+7 B (+0.15%)
dist/preact.mjs	4.76 kB	+5 B (+0.11%)
dist/preact.module.js	4.76 kB	+5 B (+0.11%)
dist/preact.umd.js	4.8 kB	+8 B (+0.17%)

ℹ️ View Unchanged

Filename	Size
compat/dist/compat.js	4.12 kB
compat/dist/compat.mjs	4.05 kB
compat/dist/compat.module.js	4.05 kB
compat/dist/compat.umd.js	4.19 kB
debug/dist/debug.js	3.82 kB
debug/dist/debug.mjs	3.82 kB
debug/dist/debug.module.js	3.82 kB
debug/dist/debug.umd.js	3.9 kB
devtools/dist/devtools.js	260 B
devtools/dist/devtools.mjs	274 B
devtools/dist/devtools.module.js	274 B
devtools/dist/devtools.umd.js	346 B
hooks/dist/hooks.js	1.54 kB
hooks/dist/hooks.mjs	1.57 kB
hooks/dist/hooks.module.js	1.57 kB
hooks/dist/hooks.umd.js	1.61 kB
jsx-runtime/dist/jsxRuntime.js	978 B
jsx-runtime/dist/jsxRuntime.mjs	952 B
jsx-runtime/dist/jsxRuntime.module.js	952 B
jsx-runtime/dist/jsxRuntime.umd.js	1.05 kB
test-utils/dist/testUtils.js	473 B
test-utils/dist/testUtils.mjs	477 B
test-utils/dist/testUtils.module.js	477 B
test-utils/dist/testUtils.umd.js	555 B

_{compressed-size-action}

[coveralls]

coverage: 99.61%. remained the same
when pulling e6a489d on avoid-cloning-reused-nodes
into 64242f4 on main.