refactor: Golf down unnecessary strict equality checks

[rschristian]

This always feels hideously dirty but most of these cases are an obvious & safe byte improvement

Makes sense that there'd be some slowdown, will go through the cases to try to find the culprit(s)

[github-actions]

📊 Tachometer Benchmark Results

Summary

duration

• create10k: unsure 🔍 -0% - +0% (-3.50ms - +4.57ms)
  ^{preact-local vs preact-main}
• filter-list: unsure 🔍 -2% - +3% (-0.35ms - +0.49ms)
  ^{preact-local vs preact-main}
• hydrate1k: unsure 🔍 -1% - +1% (-0.85ms - +1.20ms)
  ^{preact-local vs preact-main}
• many-updates: unsure 🔍 -1% - +1% (-0.14ms - +0.16ms)
  ^{preact-local vs preact-main}
• replace1k: unsure 🔍 -1% - +0% (-0.84ms - +0.22ms)
  ^{preact-local vs preact-main}
• text-update: unsure 🔍 -5% - +4% (-0.10ms - +0.09ms)
  ^{preact-local vs preact-main}
• todo: unsure 🔍 -0% - +2% (-0.17ms - +0.53ms)
  ^{preact-local vs preact-main}
• update10th1k: unsure 🔍 -5% - +1% (-1.50ms - +0.22ms)
  ^{preact-local vs preact-main}

usedJSHeapSize

• create10k: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
  ^{preact-local vs preact-main}
• filter-list: unsure 🔍 -2% - +1% (-0.03ms - +0.01ms)
  ^{preact-local vs preact-main}
• hydrate1k: unsure 🔍 -5% - +4% (-0.47ms - +0.43ms)
  ^{preact-local vs preact-main}
• many-updates: unsure 🔍 -0% - +1% (-0.02ms - +0.02ms)
  ^{preact-local vs preact-main}
• replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
  ^{preact-local vs preact-main}
• text-update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
  ^{preact-local vs preact-main}
• todo: faster ✔ 1% - 4% (0.01ms - 0.05ms)
  ^{preact-local vs preact-main}
• update10th1k: unsure 🔍 -0% - +1% (-0.01ms - +0.03ms)
  ^{preact-local vs preact-main}

Results

create10k

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4608

• Commit: 7ed5aeb

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	926.30ms - 932.50ms	-	unsure 🔍 -0% - +0% -3.50ms - +4.57ms
preact-main	926.28ms - 931.44ms	unsure 🔍 -0% - +0% -4.57ms - +3.50ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	19.18ms - 19.18ms	-	unsure 🔍 -0% - -0% -0.00ms - -0.00ms
preact-main	19.18ms - 19.19ms	unsure 🔍 +0% - +0% +0.00ms - +0.00ms	-

filter-list

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4608

• Commit: 7ed5aeb

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.46ms - 17.14ms	-	unsure 🔍 -2% - +3% -0.35ms - +0.49ms
preact-main	16.47ms - 16.98ms	unsure 🔍 -3% - +2% -0.49ms - +0.35ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.53ms - 1.56ms	-	unsure 🔍 -2% - +1% -0.03ms - +0.01ms
preact-main	1.54ms - 1.57ms	unsure 🔍 -1% - +2% -0.01ms - +0.03ms	-

hydrate1k

• Browser: chrome-headless
• Sample size: 70
• Built by: CI #4608

• Commit: 7ed5aeb

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	80.03ms - 81.34ms	-	unsure 🔍 -1% - +1% -0.85ms - +1.20ms
preact-main	79.72ms - 81.30ms	unsure 🔍 -1% - +1% -1.20ms - +0.85ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	9.43ms - 10.02ms	-	unsure 🔍 -5% - +4% -0.47ms - +0.43ms
preact-main	9.41ms - 10.08ms	unsure 🔍 -4% - +5% -0.43ms - +0.47ms	-

many-updates

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4608

• Commit: 7ed5aeb

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.39ms - 16.60ms	-	unsure 🔍 -1% - +1% -0.14ms - +0.16ms
preact-main	16.37ms - 16.59ms	unsure 🔍 -1% - +1% -0.16ms - +0.14ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.77ms - 3.80ms	-	unsure 🔍 -0% - +1% -0.02ms - +0.02ms
preact-main	3.76ms - 3.79ms	unsure 🔍 -1% - +0% -0.02ms - +0.02ms	-

replace1k

• Browser: chrome-headless
• Sample size: 100
• Built by: CI #4608

• Commit: 7ed5aeb

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	64.90ms - 65.58ms	-	unsure 🔍 -1% - +0% -0.84ms - +0.22ms
preact-main	65.14ms - 65.96ms	unsure 🔍 -0% - +1% -0.22ms - +0.84ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.98ms - 2.99ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.01ms
preact-main	2.98ms - 2.98ms	unsure 🔍 -0% - +0% -0.01ms - +0.00ms	-

run-warmup-0

Version	Avg time	vs preact-local	vs preact-main
preact-local	29.50ms - 30.23ms	-	unsure 🔍 -1% - +2% -0.35ms - +0.57ms
preact-main	29.48ms - 30.03ms	unsure 🔍 -2% - +1% -0.57ms - +0.35ms	-

run-warmup-1

Version	Avg time	vs preact-local	vs preact-main
preact-local	33.96ms - 35.05ms	-	unsure 🔍 -3% - +2% -1.03ms - +0.61ms
preact-main	34.10ms - 35.33ms	unsure 🔍 -2% - +3% -0.61ms - +1.03ms	-

run-warmup-2

Version	Avg time	vs preact-local	vs preact-main
preact-local	25.35ms - 25.64ms	-	unsure 🔍 -1% - +1% -0.30ms - +0.14ms
preact-main	25.41ms - 25.74ms	unsure 🔍 -1% - +1% -0.14ms - +0.30ms	-

run-warmup-3

Version	Avg time	vs preact-local	vs preact-main
preact-local	26.72ms - 27.40ms	-	unsure 🔍 -2% - +1% -0.55ms - +0.31ms
preact-main	26.92ms - 27.45ms	unsure 🔍 -1% - +2% -0.31ms - +0.55ms	-

run-warmup-4

Version	Avg time	vs preact-local	vs preact-main
preact-local	27.47ms - 28.02ms	-	unsure 🔍 -1% - +2% -0.24ms - +0.53ms
preact-main	27.34ms - 27.87ms	unsure 🔍 -2% - +1% -0.53ms - +0.24ms	-

run-final

Version	Avg time	vs preact-local	vs preact-main
preact-local	19.81ms - 20.17ms	-	unsure 🔍 -2% - +0% -0.48ms - +0.09ms
preact-main	19.96ms - 20.41ms	unsure 🔍 -0% - +2% -0.09ms - +0.48ms	-

text-update

• Browser: chrome-headless
• Sample size: 110
• Built by: CI #4608

• Commit: 7ed5aeb

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.00ms - 2.13ms	-	unsure 🔍 -5% - +4% -0.10ms - +0.09ms
preact-main	2.00ms - 2.14ms	unsure 🔍 -4% - +5% -0.09ms - +0.10ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.12ms - 1.12ms	-	unsure 🔍 +0% - +0% +0.00ms - +0.00ms
preact-main	1.12ms - 1.12ms	unsure 🔍 -0% - -0% -0.00ms - -0.00ms	-

todo

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4608

• Commit: 7ed5aeb

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	34.21ms - 34.60ms	-	unsure 🔍 -0% - +2% -0.17ms - +0.53ms
preact-main	33.93ms - 34.51ms	unsure 🔍 -2% - +0% -0.53ms - +0.17ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.23ms - 1.24ms	-	faster ✔ 1% - 4% 0.01ms - 0.05ms
preact-main	1.25ms - 1.29ms	slower ❌ 1% - 4% 0.01ms - 0.05ms	-

update10th1k

• Browser: chrome-headless
• Sample size: 100
• Built by: CI #4608

• Commit: 7ed5aeb

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	30.47ms - 31.61ms	-	unsure 🔍 -5% - +1% -1.50ms - +0.22ms
preact-main	31.04ms - 32.33ms	unsure 🔍 -1% - +5% -0.22ms - +1.50ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.96ms - 2.99ms	-	unsure 🔍 -0% - +1% -0.01ms - +0.03ms
preact-main	2.95ms - 2.98ms	unsure 🔍 -1% - +0% -0.03ms - +0.01ms	-

_{tachometer-reporter-action v2 for CI}

[github-actions]

Size Change: -59 B (-0.08%)

Total Size: 78.5 kB

Filename	Size	Change
dist/preact.js	4.75 kB	-13 B (-0.27%)
dist/preact.min.js	4.77 kB	-3 B (-0.06%)
dist/preact.min.module.js	4.77 kB	-16 B (-0.33%)
dist/preact.min.umd.js	4.79 kB	-4 B (-0.08%)
dist/preact.mjs	4.76 kB	-10 B (-0.21%)
dist/preact.module.js	4.76 kB	-10 B (-0.21%)
dist/preact.umd.js	4.79 kB	-3 B (-0.06%)

ℹ️ View Unchanged

Filename	Size
compat/dist/compat.js	4.12 kB
compat/dist/compat.mjs	4.05 kB
compat/dist/compat.module.js	4.05 kB
compat/dist/compat.umd.js	4.19 kB
debug/dist/debug.js	3.82 kB
debug/dist/debug.mjs	3.82 kB
debug/dist/debug.module.js	3.82 kB
debug/dist/debug.umd.js	3.9 kB
devtools/dist/devtools.js	260 B
devtools/dist/devtools.mjs	274 B
devtools/dist/devtools.module.js	274 B
devtools/dist/devtools.umd.js	346 B
hooks/dist/hooks.js	1.54 kB
hooks/dist/hooks.mjs	1.57 kB
hooks/dist/hooks.module.js	1.57 kB
hooks/dist/hooks.umd.js	1.61 kB
jsx-runtime/dist/jsxRuntime.js	978 B
jsx-runtime/dist/jsxRuntime.mjs	952 B
jsx-runtime/dist/jsxRuntime.module.js	952 B
jsx-runtime/dist/jsxRuntime.umd.js	1.05 kB
test-utils/dist/testUtils.js	473 B
test-utils/dist/testUtils.mjs	477 B
test-utils/dist/testUtils.module.js	477 B
test-utils/dist/testUtils.umd.js	555 B

_{compressed-size-action}

[coveralls]

coverage: 99.61%. remained the same
when pulling 7ed5aeb on refactor/golf-strict-eq
into ccd1e71 on main.

[JoviDeCroock]

Nice find!