types: Require initial value in useRef
#4683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschristian
commented
Feb 18, 2025
| export import CreateHandle = _hooks.CreateHandle; | ||
| export import EffectCallback = _hooks.EffectCallback; | ||
| export import Inputs = _hooks.Inputs; | ||
| export import PropRef = _hooks.PropRef; |
Member
Author
There was a problem hiding this comment.
This has never existed in React's types, not quite sure what it was supposed to be either.
| export type Key = string | number | any; | ||
|
|
||
| export type RefObject<T> = { current: T | null }; | ||
| export type RefObject<T> = { current: T }; |
Member
Author
There was a problem hiding this comment.
React for reference. Setting .current to T is much better, IMO.
| export type RefObject<T> = { current: T }; | ||
| export type RefCallback<T> = (instance: T | null) => void; | ||
| export type Ref<T> = RefObject<T> | RefCallback<T> | null; | ||
| export type Ref<T> = RefCallback<T> | RefObject<T | null> | null; |
Comment on lines
+64
to
+66
| export function useRef<T>(initialValue: T): RefObject<T>; | ||
| export function useRef<T>(initialValue: T | null): RefObject<T | null>; | ||
| export function useRef<T>(initialValue: T | undefined): RefObject<T | undefined>; |
JoviDeCroock
approved these changes
Feb 18, 2025
JoviDeCroock
pushed a commit
that referenced
this pull request
Feb 18, 2025
JoviDeCroock
pushed a commit
that referenced
this pull request
Feb 19, 2025
JoviDeCroock
pushed a commit
that referenced
this pull request
Feb 19, 2025
JoviDeCroock
pushed a commit
that referenced
this pull request
Feb 19, 2025
JoviDeCroock
pushed a commit
that referenced
this pull request
Feb 26, 2025
JoviDeCroock
pushed a commit
that referenced
this pull request
Feb 27, 2025
JoviDeCroock
pushed a commit
that referenced
this pull request
Mar 1, 2025
JoviDeCroock
pushed a commit
that referenced
this pull request
Mar 9, 2025
JoviDeCroock
pushed a commit
that referenced
this pull request
Mar 14, 2025
JoviDeCroock
pushed a commit
that referenced
this pull request
Mar 22, 2025
JoviDeCroock
pushed a commit
that referenced
this pull request
Apr 8, 2025
JoviDeCroock
pushed a commit
that referenced
this pull request
May 3, 2025
JoviDeCroock
pushed a commit
that referenced
this pull request
May 8, 2025
JoviDeCroock
pushed a commit
that referenced
this pull request
May 23, 2025
JoviDeCroock
pushed a commit
that referenced
this pull request
May 30, 2025
JoviDeCroock
pushed a commit
that referenced
this pull request
Jun 6, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I quite like the change React made to their types in v19 to require an initial argument be passed to
useRef, it fixes some of the fiddly details ofuseRefthat are really easy to stumble into. This is a breaking type change so v11 it goes.