Review feedback v11 #4655

JoviDeCroock · 2025-02-12T08:41:08Z

No description provided.

github-actions · 2025-02-12T08:41:39Z

📊 Tachometer Benchmark Results

Summary

duration

create10k: unsure 🔍 -1% - +0% (-8.49ms - +3.16ms)
^{preact-local vs preact-main}
filter-list: unsure 🔍 -1% - +3% (-0.21ms - +0.47ms)
^{preact-local vs preact-main}
hydrate1k: unsure 🔍 -2% - +2% (-1.23ms - +1.44ms)
^{preact-local vs preact-main}
many-updates: unsure 🔍 -1% - +2% (-0.18ms - +0.41ms)
^{preact-local vs preact-main}
replace1k: unsure 🔍 -1% - +1% (-0.70ms - +0.61ms)
^{preact-local vs preact-main}
text-update: unsure 🔍 -4% - +5% (-0.09ms - +0.10ms)
^{preact-local vs preact-main}
todo: unsure 🔍 -2% - +0% (-0.65ms - +0.10ms)
^{preact-local vs preact-main}
update10th1k: unsure 🔍 -5% - +3% (-1.49ms - +0.81ms)
^{preact-local vs preact-main}

usedJSHeapSize

create10k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
^{preact-local vs preact-main}
filter-list: unsure 🔍 -1% - +1% (-0.01ms - +0.02ms)
^{preact-local vs preact-main}
hydrate1k: unsure 🔍 -3% - +5% (-0.27ms - +0.50ms)
^{preact-local vs preact-main}
many-updates: unsure 🔍 -1% - +0% (-0.03ms - +0.01ms)
^{preact-local vs preact-main}
replace1k: unsure 🔍 -0% - +1% (-0.01ms - +0.03ms)
^{preact-local vs preact-main}
text-update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
^{preact-local vs preact-main}
todo: unsure 🔍 -0% - +3% (-0.00ms - +0.04ms)
^{preact-local vs preact-main}
update10th1k: unsure 🔍 -1% - +0% (-0.02ms - +0.01ms)
^{preact-local vs preact-main}

Results

create10k

Browser: chrome-headless
Sample size: 50
Built by: CI #4323
Commit: 897265a

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	936.87ms - 942.58ms	-	unsure 🔍 -1% - +0% -8.49ms - +3.16ms
preact-main	937.31ms - 947.46ms	unsure 🔍 -0% - +1% -3.16ms - +8.49ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	19.20ms - 19.20ms	-	unsure 🔍 +0% - +0% +0.00ms - +0.00ms
preact-main	19.20ms - 19.20ms	unsure 🔍 -0% - -0% -0.00ms - -0.00ms	-

filter-list

Browser: chrome-headless
Sample size: 50
Built by: CI #4323
Commit: 897265a

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.55ms - 17.15ms	-	unsure 🔍 -1% - +3% -0.21ms - +0.47ms
preact-main	16.58ms - 16.86ms	unsure 🔍 -3% - +1% -0.47ms - +0.21ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.51ms - 1.53ms	-	unsure 🔍 -1% - +1% -0.01ms - +0.02ms
preact-main	1.50ms - 1.53ms	unsure 🔍 -1% - +1% -0.02ms - +0.01ms	-

hydrate1k

Browser: chrome-headless
Sample size: 90
Built by: CI #4323
Commit: 897265a

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	79.87ms - 81.49ms	-	unsure 🔍 -2% - +2% -1.23ms - +1.44ms
preact-main	79.51ms - 81.64ms	unsure 🔍 -2% - +2% -1.44ms - +1.23ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	9.67ms - 10.22ms	-	unsure 🔍 -3% - +5% -0.27ms - +0.50ms
preact-main	9.56ms - 10.10ms	unsure 🔍 -5% - +3% -0.50ms - +0.27ms	-

many-updates

Browser: chrome-headless
Sample size: 50
Built by: CI #4323
Commit: 897265a

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.69ms - 17.14ms	-	unsure 🔍 -1% - +2% -0.18ms - +0.41ms
preact-main	16.62ms - 17.00ms	unsure 🔍 -2% - +1% -0.41ms - +0.18ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.75ms - 3.76ms	-	unsure 🔍 -1% - +0% -0.03ms - +0.01ms
preact-main	3.75ms - 3.78ms	unsure 🔍 -0% - +1% -0.01ms - +0.03ms	-

replace1k

Browser: chrome-headless
Sample size: 100
Built by: CI #4323
Commit: 897265a

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	64.89ms - 65.79ms	-	unsure 🔍 -1% - +1% -0.70ms - +0.61ms
preact-main	64.90ms - 65.86ms	unsure 🔍 -1% - +1% -0.61ms - +0.70ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.96ms - 2.99ms	-	unsure 🔍 -0% - +1% -0.01ms - +0.03ms
preact-main	2.96ms - 2.98ms	unsure 🔍 -1% - +0% -0.03ms - +0.01ms	-

run-warmup-0

Version	Avg time	vs preact-local	vs preact-main
preact-local	30.26ms - 30.99ms	-	slower ❌ 1% - 4% 0.26ms - 1.13ms
preact-main	29.69ms - 30.16ms	faster ✔ 1% - 4% 0.26ms - 1.13ms	-

run-warmup-1

Version	Avg time	vs preact-local	vs preact-main
preact-local	33.26ms - 33.95ms	-	unsure 🔍 -2% - +1% -0.61ms - +0.45ms
preact-main	33.28ms - 34.08ms	unsure 🔍 -1% - +2% -0.45ms - +0.61ms	-

run-warmup-2

Version	Avg time	vs preact-local	vs preact-main
preact-local	25.92ms - 26.34ms	-	unsure 🔍 -1% - +1% -0.23ms - +0.38ms
preact-main	25.84ms - 26.27ms	unsure 🔍 -1% - +1% -0.38ms - +0.23ms	-

run-warmup-3

Version	Avg time	vs preact-local	vs preact-main
preact-local	26.04ms - 27.34ms	-	slower ❌ 0% - 7% 0.05ms - 1.76ms
preact-main	25.23ms - 26.33ms	faster ✔ 0% - 7% 0.05ms - 1.76ms	-

run-warmup-4

Version	Avg time	vs preact-local	vs preact-main
preact-local	25.23ms - 26.57ms	-	unsure 🔍 -2% - +6% -0.42ms - +1.43ms
preact-main	24.76ms - 26.02ms	unsure 🔍 -5% - +2% -1.43ms - +0.42ms	-

run-final

Version	Avg time	vs preact-local	vs preact-main
preact-local	20.36ms - 20.78ms	-	unsure 🔍 -1% - +1% -0.26ms - +0.29ms
preact-main	20.38ms - 20.74ms	unsure 🔍 -1% - +1% -0.29ms - +0.26ms	-

text-update

Browser: chrome-headless
Sample size: 90
Built by: CI #4323
Commit: 897265a

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.99ms - 2.12ms	-	unsure 🔍 -4% - +5% -0.09ms - +0.10ms
preact-main	1.99ms - 2.11ms	unsure 🔍 -5% - +4% -0.10ms - +0.09ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.11ms - 1.11ms	-	unsure 🔍 +0% - +0% +0.00ms - +0.00ms
preact-main	1.11ms - 1.11ms	unsure 🔍 -0% - -0% -0.00ms - -0.00ms	-

todo

Browser: chrome-headless
Sample size: 50
Built by: CI #4323
Commit: 897265a

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	33.55ms - 33.86ms	-	unsure 🔍 -2% - +0% -0.65ms - +0.10ms
preact-main	33.63ms - 34.32ms	unsure 🔍 -0% - +2% -0.10ms - +0.65ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.23ms - 1.26ms	-	unsure 🔍 -0% - +3% -0.00ms - +0.04ms
preact-main	1.21ms - 1.24ms	unsure 🔍 -3% - +0% -0.04ms - +0.00ms	-

update10th1k

Browser: chrome-headless
Sample size: 50
Built by: CI #4323
Commit: 897265a

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	30.53ms - 32.38ms	-	unsure 🔍 -5% - +3% -1.49ms - +0.81ms
preact-main	31.11ms - 32.48ms	unsure 🔍 -3% - +5% -0.81ms - +1.49ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.90ms - 2.92ms	-	unsure 🔍 -1% - +0% -0.02ms - +0.01ms
preact-main	2.90ms - 2.93ms	unsure 🔍 -0% - +1% -0.01ms - +0.02ms	-

_{tachometer-reporter-action v2 for CI}

github-actions · 2025-02-12T08:42:22Z

Size Change: +155 B (+0.25%)

Total Size: 61 kB

Filename	Size	Change
`dist/preact.js`	4.62 kB	+25 B (+0.54%)
`dist/preact.min.js`	4.66 kB	+28 B (+0.6%)
`dist/preact.min.module.js`	4.65 kB	+25 B (+0.54%)
`dist/preact.min.umd.js`	4.69 kB	+22 B (+0.47%)
`dist/preact.module.js`	4.65 kB	+32 B (+0.69%)
`dist/preact.umd.js`	4.71 kB	+23 B (+0.49%)

ℹ️ View Unchanged

Filename	Size
`compat/dist/compat.js`	3.78 kB
`compat/dist/compat.module.js`	3.7 kB
`compat/dist/compat.umd.js`	3.84 kB
`debug/dist/debug.js`	3.83 kB
`debug/dist/debug.module.js`	3.83 kB
`debug/dist/debug.umd.js`	3.9 kB
`devtools/dist/devtools.js`	260 B
`devtools/dist/devtools.module.js`	274 B
`devtools/dist/devtools.umd.js`	346 B
`hooks/dist/hooks.js`	1.54 kB
`hooks/dist/hooks.module.js`	1.57 kB
`hooks/dist/hooks.umd.js`	1.61 kB
`jsx-runtime/dist/jsxRuntime.js`	978 B
`jsx-runtime/dist/jsxRuntime.module.js`	952 B
`jsx-runtime/dist/jsxRuntime.umd.js`	1.05 kB
`test-utils/dist/testUtils.js`	473 B
`test-utils/dist/testUtils.module.js`	477 B
`test-utils/dist/testUtils.umd.js`	555 B

_{compressed-size-action}

rschristian · 2025-02-12T08:46:00Z

src/index.d.ts

-/**
- * @deprecated Will be removed in v11.
- *
- * Replacement Preact 10+ implementation can be found here: https://gist.github.com/developit/f4c67a2ede71dc2fab7f357f39cff28c


Good spot, had completely forgotten about this

* Revert assign and avoid repeating indexed access * Check parentNode instead * Use flag * Remove type * Remove todo file

JoviDeCroock added 3 commits February 12, 2025 09:36

Revert assign and avoid repeating indexed access

2c9d8fb

Check parentNode instead

063358d

Use flag

9c160d7

JoviDeCroock requested a review from rschristian February 12, 2025 08:41

Remove type

91d06e5

Remove todo file

897265a

rschristian approved these changes Feb 12, 2025

View reviewed changes

JoviDeCroock merged commit 2516268 into v11-2 Feb 12, 2025
12 checks passed

JoviDeCroock deleted the review-feedback-v11 branch February 12, 2025 08:47

JoviDeCroock added a commit that referenced this pull request Feb 13, 2025

Review feedback v11 (#4655)

756f8a7

* Revert assign and avoid repeating indexed access * Check parentNode instead * Use flag * Remove type * Remove todo file

JoviDeCroock added a commit that referenced this pull request Feb 18, 2025

Review feedback v11 (#4655)

ea9b9fc

* Revert assign and avoid repeating indexed access * Check parentNode instead * Use flag * Remove type * Remove todo file

JoviDeCroock added a commit that referenced this pull request Feb 19, 2025

Review feedback v11 (#4655)

1e4c66b

* Revert assign and avoid repeating indexed access * Check parentNode instead * Use flag * Remove type * Remove todo file

JoviDeCroock added a commit that referenced this pull request Feb 26, 2025

Review feedback v11 (#4655)

1a03075

* Revert assign and avoid repeating indexed access * Check parentNode instead * Use flag * Remove type * Remove todo file

JoviDeCroock added a commit that referenced this pull request Feb 27, 2025

Review feedback v11 (#4655)

38c1a72

* Revert assign and avoid repeating indexed access * Check parentNode instead * Use flag * Remove type * Remove todo file

JoviDeCroock added a commit that referenced this pull request Mar 1, 2025

Review feedback v11 (#4655)

ec216c5

* Revert assign and avoid repeating indexed access * Check parentNode instead * Use flag * Remove type * Remove todo file

JoviDeCroock added a commit that referenced this pull request Mar 9, 2025

Review feedback v11 (#4655)

79c2974

* Revert assign and avoid repeating indexed access * Check parentNode instead * Use flag * Remove type * Remove todo file

JoviDeCroock added a commit that referenced this pull request Mar 14, 2025

Review feedback v11 (#4655)

35694ac

* Revert assign and avoid repeating indexed access * Check parentNode instead * Use flag * Remove type * Remove todo file

JoviDeCroock added a commit that referenced this pull request Mar 22, 2025

Review feedback v11 (#4655)

66e5e3e

* Revert assign and avoid repeating indexed access * Check parentNode instead * Use flag * Remove type * Remove todo file

JoviDeCroock added a commit that referenced this pull request Apr 8, 2025

Review feedback v11 (#4655)

d837b75

* Revert assign and avoid repeating indexed access * Check parentNode instead * Use flag * Remove type * Remove todo file

JoviDeCroock added a commit that referenced this pull request May 3, 2025

Review feedback v11 (#4655)

32945a6

* Revert assign and avoid repeating indexed access * Check parentNode instead * Use flag * Remove type * Remove todo file

JoviDeCroock added a commit that referenced this pull request May 8, 2025

Review feedback v11 (#4655)

f6a74dd

* Revert assign and avoid repeating indexed access * Check parentNode instead * Use flag * Remove type * Remove todo file

JoviDeCroock added a commit that referenced this pull request May 23, 2025

Review feedback v11 (#4655)

e7350d5

* Revert assign and avoid repeating indexed access * Check parentNode instead * Use flag * Remove type * Remove todo file

JoviDeCroock added a commit that referenced this pull request May 30, 2025

Review feedback v11 (#4655)

efb4feb

* Revert assign and avoid repeating indexed access * Check parentNode instead * Use flag * Remove type * Remove todo file

JoviDeCroock added a commit that referenced this pull request Jun 6, 2025

Review feedback v11 (#4655)

458bedf

* Revert assign and avoid repeating indexed access * Check parentNode instead * Use flag * Remove type * Remove todo file

Uh oh!

Review feedback v11 #4655

Review feedback v11 #4655

Uh oh!

Conversation

JoviDeCroock commented Feb 12, 2025

Uh oh!

github-actions bot commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

duration

usedJSHeapSize

Results

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

run-warmup-0

run-warmup-1

run-warmup-2

run-warmup-3

run-warmup-4

run-final

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

Uh oh!

github-actions bot commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rschristian Feb 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Feb 12, 2025 •

edited

Loading

github-actions bot commented Feb 12, 2025 •

edited

Loading