Skip to content

types: Correct HTMLProps to extend all known props #4651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoviDeCroock merged 1 commit into from
Feb 11, 2025
Merged

types: Correct HTMLProps to extend all known props #4651

JoviDeCroock merged 1 commit into from
Feb 11, 2025

Conversation

@rschristian
Copy link
Member

@rschristian rschristian commented Feb 11, 2025

HTMLAttributes used to contain everything, #4546 cut it down to only the truly global properties though. AllHTMLAttributes is what we want, mirroring React

@JoviDeCroock JoviDeCroock merged commit 52735c8 into main Feb 11, 2025
4 checks passed
@JoviDeCroock JoviDeCroock deleted the types/html-props branch February 11, 2025 08:41
@coveralls
Copy link

coveralls commented Feb 13, 2025

Coverage Status

coverage: 99.618%. remained the same
when pulling 5991695 on types/html-props
into 3ff5f50 on main.

@JoviDeCroock JoviDeCroock mentioned this pull request Feb 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rschristian @coveralls @JoviDeCroock