Skip to content

fix max and min type definition to allow number #4598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rschristian merged 1 commit into from
Dec 7, 2024
Merged

fix max and min type definition to allow number #4598

rschristian merged 1 commit into from
Dec 7, 2024

Conversation

@devlux
Copy link
Contributor

@devlux devlux commented Dec 7, 2024

fixes #4597

@devlux devlux mentioned this pull request Dec 7, 2024
Merged
rschristian
rschristian approved these changes Dec 7, 2024
View reviewed changes
Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers

@rschristian rschristian merged commit dee5673 into preactjs:main Dec 7, 2024
4 checks passed
@coveralls
Copy link

coveralls commented Dec 7, 2024

Coverage Status

coverage: 99.617%. remained the same
when pulling 11529cc on devlux:main
into b864138 on preactjs:main.

@julienw julienw mentioned this pull request Dec 11, 2024
Merged
@JoviDeCroock JoviDeCroock mentioned this pull request Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

@rschristian rschristian rschristian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

min and max type definition for MeterHTMLAttributes and ProgressHTMLAttributes are missing number

4 participants

@devlux @coveralls @JoviDeCroock @rschristian