Fix portal children ordering

[JoviDeCroock]

Fixes #4572

Technically appendChild isn't needed anymore as our diffing algorithm only uses insertBefore - also facepalm at this bug 😅

[github-actions]

📊 Tachometer Benchmark Results

Summary

duration

• create10k: unsure 🔍 -0% - +1% (-1.27ms - +6.79ms)
  ^{preact-local vs preact-main}
• filter-list: unsure 🔍 -3% - +1% (-0.58ms - +0.14ms)
  ^{preact-local vs preact-main}
• hydrate1k: unsure 🔍 -1% - +3% (-1.07ms - +1.95ms)
  ^{preact-local vs preact-main}
• many-updates: unsure 🔍 -1% - +4% (-0.19ms - +0.63ms)
  ^{preact-local vs preact-main}
• replace1k: unsure 🔍 -1% - +1% (-0.78ms - +0.37ms)
  ^{preact-local vs preact-main}
• text-update: unsure 🔍 -1% - +7% (-0.02ms - +0.15ms)
  ^{preact-local vs preact-main}
• todo: unsure 🔍 -2% - +1% (-0.53ms - +0.26ms)
  ^{preact-local vs preact-main}
• update10th1k: unsure 🔍 -4% - +2% (-1.34ms - +0.72ms)
  ^{preact-local vs preact-main}

usedJSHeapSize

• create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
  ^{preact-local vs preact-main}
• filter-list: unsure 🔍 -1% - +2% (-0.01ms - +0.03ms)
  ^{preact-local vs preact-main}
• hydrate1k: unsure 🔍 -6% - +1% (-0.78ms - +0.20ms)
  ^{preact-local vs preact-main}
• many-updates: unsure 🔍 -0% - +0% (-0.02ms - +0.01ms)
  ^{preact-local vs preact-main}
• replace1k: unsure 🔍 -1% - +1% (-0.02ms - +0.02ms)
  ^{preact-local vs preact-main}
• text-update: unsure 🔍 -1% - +0% (-0.01ms - +0.00ms)
  ^{preact-local vs preact-main}
• todo: unsure 🔍 -1% - +0% (-0.01ms - +0.00ms)
  ^{preact-local vs preact-main}
• update10th1k: unsure 🔍 -1% - +0% (-0.02ms - +0.02ms)
  ^{preact-local vs preact-main}

Results

create10k

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4093

• Commit: 25f1ff5

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	944.82ms - 950.77ms	-	unsure 🔍 -0% - +1% -1.27ms - +6.79ms
preact-main	942.32ms - 947.76ms	unsure 🔍 -1% - +0% -6.79ms - +1.27ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	24.84ms - 24.84ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-main	24.84ms - 24.84ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

filter-list

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4093

• Commit: 25f1ff5

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.55ms - 16.66ms	-	unsure 🔍 -3% - +1% -0.58ms - +0.14ms
preact-main	16.47ms - 17.18ms	unsure 🔍 -1% - +3% -0.14ms - +0.58ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.66ms - 1.69ms	-	unsure 🔍 -1% - +2% -0.01ms - +0.03ms
preact-main	1.65ms - 1.67ms	unsure 🔍 -2% - +1% -0.03ms - +0.01ms	-

hydrate1k

• Browser: chrome-headless
• Sample size: 90
• Built by: CI #4093

• Commit: 25f1ff5

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	74.57ms - 76.92ms	-	unsure 🔍 -1% - +3% -1.07ms - +1.95ms
preact-main	74.35ms - 76.25ms	unsure 🔍 -3% - +1% -1.95ms - +1.07ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	12.95ms - 13.66ms	-	unsure 🔍 -6% - +1% -0.78ms - +0.20ms
preact-main	13.26ms - 13.93ms	unsure 🔍 -2% - +6% -0.20ms - +0.78ms	-

many-updates

• Browser: chrome-headless
• Sample size: 60
• Built by: CI #4093

• Commit: 25f1ff5

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	15.46ms - 16.00ms	-	unsure 🔍 -1% - +4% -0.19ms - +0.63ms
preact-main	15.21ms - 15.81ms	unsure 🔍 -4% - +1% -0.63ms - +0.19ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	4.50ms - 4.51ms	-	unsure 🔍 -0% - +0% -0.02ms - +0.01ms
preact-main	4.50ms - 4.52ms	unsure 🔍 -0% - +0% -0.01ms - +0.02ms	-

replace1k

• Browser: chrome-headless
• Sample size: 100
• Built by: CI #4093

• Commit: 25f1ff5

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	65.73ms - 66.33ms	-	unsure 🔍 -1% - +1% -0.78ms - +0.37ms
preact-main	65.74ms - 66.72ms	unsure 🔍 -1% - +1% -0.37ms - +0.78ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.58ms - 3.60ms	-	unsure 🔍 -1% - +1% -0.02ms - +0.02ms
preact-main	3.58ms - 3.61ms	unsure 🔍 -1% - +1% -0.02ms - +0.02ms	-

run-warmup-0

Version	Avg time	vs preact-local	vs preact-main
preact-local	29.97ms - 30.49ms	-	unsure 🔍 -2% - +0% -0.65ms - +0.14ms
preact-main	30.18ms - 30.78ms	unsure 🔍 -0% - +2% -0.14ms - +0.65ms	-

run-warmup-1

Version	Avg time	vs preact-local	vs preact-main
preact-local	34.46ms - 35.80ms	-	unsure 🔍 -4% - +1% -1.60ms - +0.30ms
preact-main	35.10ms - 36.45ms	unsure 🔍 -1% - +5% -0.30ms - +1.60ms	-

run-warmup-2

Version	Avg time	vs preact-local	vs preact-main
preact-local	29.34ms - 30.24ms	-	unsure 🔍 -2% - +3% -0.63ms - +0.75ms
preact-main	29.21ms - 30.26ms	unsure 🔍 -3% - +2% -0.75ms - +0.63ms	-

run-warmup-3

Version	Avg time	vs preact-local	vs preact-main
preact-local	22.27ms - 22.64ms	-	unsure 🔍 -1% - +2% -0.20ms - +0.39ms
preact-main	22.13ms - 22.59ms	unsure 🔍 -2% - +1% -0.39ms - +0.20ms	-

run-warmup-4

Version	Avg time	vs preact-local	vs preact-main
preact-local	20.84ms - 21.05ms	-	unsure 🔍 -1% - +1% -0.14ms - +0.18ms
preact-main	20.80ms - 21.04ms	unsure 🔍 -1% - +1% -0.18ms - +0.14ms	-

run-final

Version	Avg time	vs preact-local	vs preact-main
preact-local	20.00ms - 20.53ms	-	unsure 🔍 -2% - +2% -0.35ms - +0.43ms
preact-main	19.95ms - 20.51ms	unsure 🔍 -2% - +2% -0.43ms - +0.35ms	-

text-update

• Browser: chrome-headless
• Sample size: 220
• Built by: CI #4093

• Commit: 25f1ff5

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.09ms - 2.22ms	-	unsure 🔍 -1% - +7% -0.02ms - +0.15ms
preact-main	2.04ms - 2.15ms	unsure 🔍 -7% - +1% -0.15ms - +0.02ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.10ms - 1.11ms	-	unsure 🔍 -1% - +0% -0.01ms - +0.00ms
preact-main	1.11ms - 1.11ms	unsure 🔍 -0% - +1% -0.00ms - +0.01ms	-

todo

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4093

• Commit: 25f1ff5

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	33.82ms - 34.19ms	-	unsure 🔍 -2% - +1% -0.53ms - +0.26ms
preact-main	33.80ms - 34.49ms	unsure 🔍 -1% - +2% -0.26ms - +0.53ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.22ms - 1.22ms	-	unsure 🔍 -1% - +0% -0.01ms - +0.00ms
preact-main	1.22ms - 1.23ms	unsure 🔍 -0% - +1% -0.00ms - +0.01ms	-

update10th1k

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4093

• Commit: 25f1ff5

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	35.30ms - 36.56ms	-	unsure 🔍 -4% - +2% -1.34ms - +0.72ms
preact-main	35.43ms - 37.06ms	unsure 🔍 -2% - +4% -0.72ms - +1.34ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.47ms - 3.49ms	-	unsure 🔍 -1% - +0% -0.02ms - +0.02ms
preact-main	3.47ms - 3.50ms	unsure 🔍 -0% - +1% -0.02ms - +0.02ms	-

_{tachometer-reporter-action v2 for CI}

[github-actions]

Size Change: +14 B (+0.02%)

Total Size: 62.5 kB

Filename	Size	Change
compat/dist/compat.js	4.13 kB	+5 B (+0.12%)
compat/dist/compat.module.js	4.06 kB	+4 B (+0.1%)
compat/dist/compat.umd.js	4.2 kB	+5 B (+0.12%)

ℹ️ View Unchanged

Filename	Size
debug/dist/debug.js	3.82 kB
debug/dist/debug.module.js	3.83 kB
debug/dist/debug.umd.js	3.9 kB
devtools/dist/devtools.js	260 B
devtools/dist/devtools.module.js	274 B
devtools/dist/devtools.umd.js	346 B
dist/preact.js	4.74 kB
dist/preact.min.js	4.75 kB
dist/preact.min.module.js	4.76 kB
dist/preact.min.umd.js	4.78 kB
dist/preact.module.js	4.76 kB
dist/preact.umd.js	4.79 kB
hooks/dist/hooks.js	1.52 kB
hooks/dist/hooks.module.js	1.56 kB
hooks/dist/hooks.umd.js	1.6 kB
jsx-runtime/dist/jsxRuntime.js	973 B
jsx-runtime/dist/jsxRuntime.module.js	947 B
jsx-runtime/dist/jsxRuntime.umd.js	1.05 kB
test-utils/dist/testUtils.js	451 B
test-utils/dist/testUtils.module.js	456 B
test-utils/dist/testUtils.umd.js	536 B

_{compressed-size-action}

[coveralls]

coverage: 99.616% (+0.1%) from 99.488%
when pulling 25f1ff5 on fix-portal-children
into bd14437 on main.

[rschristian]

Ha! How have none of use spotted that?