Skip to content

Allow rendering in document #4564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoviDeCroock merged 3 commits into from
Nov 24, 2024
Merged

Allow rendering in document #4564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d693ae
Allow rendering in document
JoviDeCroock Nov 22, 2024
e833b97
Add test
JoviDeCroock Nov 22, 2024
c08c63e
Merge branch 'main' into allow-rendering-in-doc
JoviDeCroock Nov 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/render.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ import { slice } from './util';
* existing DOM tree rooted at `replaceNode`
*/
export function render(vnode, parentDom, replaceNode) {
// https://github.com/preactjs/preact/issues/3794
if (parentDom === document) {
parentDom = document.documentElement;
}

if (options._root) options._root(vnode, parentDom);

// We abuse the `replaceNode` parameter in `hydrate()` to signal if we are in
Expand Down
2 changes: 2 additions & 0 deletions test/_util/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,8 @@ export function clearOptions() {
* @param {HTMLElement} scratch
*/
export function teardown(scratch) {
if (!document.contains(scratch)) return;

if (
scratch &&
('__k' in scratch || '_children' in scratch) &&
Expand Down
20 changes: 19 additions & 1 deletion test/browser/render.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { setupRerender } from 'preact/test-utils';
import { createElement, render, Component, options } from 'preact';
import { createElement, render, Component, options, Fragment } from 'preact';
import {
setupScratch,
teardown,
Expand Down Expand Up @@ -1884,4 +1884,22 @@ describe('render()', () => {
);
}
});

it('should work with document', () => {
document.textContent = '';
const App = () => (
<Fragment>
<head>
<title>Test</title>
</head>
<body>
<p>Test</p>
</body>
</Fragment>
);
render(<App />, document);
expect(document.documentElement.innerHTML).to.equal(
'<head><title>Test</title></head><body><p>Test</p></body>\n'
);
});
});