Handle errors during hydration

[JoviDeCroock]

Resolves #2539

I guess this is a choice we have to make, this fixes our hydration algorithm to only think about resumed hydration when our caught error is a Promise.

[github-actions]

📊 Tachometer Benchmark Results

Summary

duration

• create10k: unsure 🔍 -1% - +0% (-4.83ms - +2.13ms)
  ^{preact-local vs preact-main}
• filter-list: unsure 🔍 -1% - +0% (-0.15ms - +0.04ms)
  ^{preact-local vs preact-main}
• hydrate1k: unsure 🔍 -1% - +2% (-1.12ms - +1.35ms)
  ^{preact-local vs preact-main}
• many-updates: unsure 🔍 -4% - +3% (-0.65ms - +0.40ms)
  ^{preact-local vs preact-main}
• replace1k: unsure 🔍 -1% - +1% (-0.75ms - +0.82ms)
  ^{preact-local vs preact-main}
• text-update: unsure 🔍 -7% - +3% (-0.15ms - +0.06ms)
  ^{preact-local vs preact-main}
• todo: unsure 🔍 -5% - +2% (-1.64ms - +0.73ms)
  ^{preact-local vs preact-main}
• update10th1k: unsure 🔍 -2% - +4% (-0.87ms - +1.53ms)
  ^{preact-local vs preact-main}

usedJSHeapSize

• create10k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
  ^{preact-local vs preact-main}
• filter-list: unsure 🔍 -1% - +0% (-0.02ms - +0.01ms)
  ^{preact-local vs preact-main}
• hydrate1k: unsure 🔍 -6% - +0% (-0.88ms - +0.07ms)
  ^{preact-local vs preact-main}
• many-updates: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
  ^{preact-local vs preact-main}
• replace1k: unsure 🔍 -1% - +0% (-0.02ms - +0.02ms)
  ^{preact-local vs preact-main}
• text-update: unsure 🔍 -0% - +1% (-0.00ms - +0.01ms)
  ^{preact-local vs preact-main}
• todo: unsure 🔍 -1% - +1% (-0.01ms - +0.01ms)
  ^{preact-local vs preact-main}
• update10th1k: unsure 🔍 -0% - +1% (-0.00ms - +0.02ms)
  ^{preact-local vs preact-main}

Results

create10k

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4063

• Commit: 38080ea

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	950.08ms - 954.94ms	-	unsure 🔍 -1% - +0% -4.83ms - +2.13ms
preact-main	951.38ms - 956.34ms	unsure 🔍 -0% - +1% -2.13ms - +4.83ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	24.84ms - 24.84ms	-	unsure 🔍 +0% - +0% +0.00ms - +0.00ms
preact-main	24.84ms - 24.84ms	unsure 🔍 -0% - -0% -0.00ms - -0.00ms	-

filter-list

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4063

• Commit: 38080ea

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.57ms - 16.66ms	-	unsure 🔍 -1% - +0% -0.15ms - +0.04ms
preact-main	16.59ms - 16.76ms	unsure 🔍 -0% - +1% -0.04ms - +0.15ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.65ms - 1.66ms	-	unsure 🔍 -1% - +0% -0.02ms - +0.01ms
preact-main	1.65ms - 1.67ms	unsure 🔍 -0% - +1% -0.01ms - +0.02ms	-

hydrate1k

• Browser: chrome-headless
• Sample size: 90
• Built by: CI #4063

• Commit: 38080ea

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	75.68ms - 77.86ms	-	unsure 🔍 -1% - +2% -1.12ms - +1.35ms
preact-main	76.08ms - 77.24ms	unsure 🔍 -2% - +1% -1.35ms - +1.12ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	12.81ms - 13.50ms	-	unsure 🔍 -6% - +0% -0.88ms - +0.07ms
preact-main	13.23ms - 13.89ms	unsure 🔍 -1% - +7% -0.07ms - +0.88ms	-

many-updates

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4063

• Commit: 38080ea

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	15.50ms - 16.11ms	-	unsure 🔍 -4% - +3% -0.65ms - +0.40ms
preact-main	15.50ms - 16.36ms	unsure 🔍 -3% - +4% -0.40ms - +0.65ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	4.49ms - 4.50ms	-	unsure 🔍 -0% - +0% -0.01ms - +0.01ms
preact-main	4.49ms - 4.51ms	unsure 🔍 -0% - +0% -0.01ms - +0.01ms	-

replace1k

• Browser: chrome-headless
• Sample size: 100
• Built by: CI #4063

• Commit: 38080ea

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	68.32ms - 69.41ms	-	unsure 🔍 -1% - +1% -0.75ms - +0.82ms
preact-main	68.26ms - 69.40ms	unsure 🔍 -1% - +1% -0.82ms - +0.75ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.56ms - 3.59ms	-	unsure 🔍 -1% - +0% -0.02ms - +0.02ms
preact-main	3.56ms - 3.59ms	unsure 🔍 -0% - +1% -0.02ms - +0.02ms	-

run-warmup-0

Version	Avg time	vs preact-local	vs preact-main
preact-local	30.96ms - 31.62ms	-	unsure 🔍 -1% - +2% -0.26ms - +0.66ms
preact-main	30.76ms - 31.41ms	unsure 🔍 -2% - +1% -0.66ms - +0.26ms	-

run-warmup-1

Version	Avg time	vs preact-local	vs preact-main
preact-local	36.36ms - 37.53ms	-	faster ✔ 0% - 5% 0.01ms - 1.75ms
preact-main	37.18ms - 38.47ms	slower ❌ 0% - 5% 0.01ms - 1.75ms	-

run-warmup-2

Version	Avg time	vs preact-local	vs preact-main
preact-local	30.17ms - 31.20ms	-	unsure 🔍 -2% - +3% -0.71ms - +0.77ms
preact-main	30.12ms - 31.19ms	unsure 🔍 -3% - +2% -0.77ms - +0.71ms	-

run-warmup-3

Version	Avg time	vs preact-local	vs preact-main
preact-local	22.88ms - 23.37ms	-	unsure 🔍 -1% - +2% -0.28ms - +0.40ms
preact-main	22.84ms - 23.30ms	unsure 🔍 -2% - +1% -0.40ms - +0.28ms	-

run-warmup-4

Version	Avg time	vs preact-local	vs preact-main
preact-local	21.79ms - 22.04ms	-	unsure 🔍 -3% - +0% -0.75ms - +0.09ms
preact-main	21.84ms - 22.65ms	unsure 🔍 -0% - +3% -0.09ms - +0.75ms	-

run-final

Version	Avg time	vs preact-local	vs preact-main
preact-local	20.35ms - 20.83ms	-	unsure 🔍 -2% - +1% -0.50ms - +0.21ms
preact-main	20.47ms - 21.00ms	unsure 🔍 -1% - +2% -0.21ms - +0.50ms	-

text-update

• Browser: chrome-headless
• Sample size: 220
• Built by: CI #4063

• Commit: 38080ea

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.02ms - 2.18ms	-	unsure 🔍 -7% - +3% -0.15ms - +0.06ms
preact-main	2.08ms - 2.21ms	unsure 🔍 -3% - +7% -0.06ms - +0.15ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.10ms - 1.11ms	-	unsure 🔍 -0% - +1% -0.00ms - +0.01ms
preact-main	1.10ms - 1.11ms	unsure 🔍 -1% - +0% -0.01ms - +0.00ms	-

todo

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4063

• Commit: 38080ea

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	33.48ms - 34.19ms	-	unsure 🔍 -5% - +2% -1.64ms - +0.73ms
preact-main	33.15ms - 35.41ms	unsure 🔍 -2% - +5% -0.73ms - +1.64ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.22ms - 1.23ms	-	unsure 🔍 -1% - +1% -0.01ms - +0.01ms
preact-main	1.22ms - 1.23ms	unsure 🔍 -1% - +1% -0.01ms - +0.01ms	-

update10th1k

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4063

• Commit: 38080ea

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	34.76ms - 36.28ms	-	unsure 🔍 -2% - +4% -0.87ms - +1.53ms
preact-main	34.26ms - 36.12ms	unsure 🔍 -4% - +2% -1.53ms - +0.87ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.47ms - 3.49ms	-	unsure 🔍 -0% - +1% -0.00ms - +0.02ms
preact-main	3.47ms - 3.48ms	unsure 🔍 -1% - +0% -0.02ms - +0.00ms	-

_{tachometer-reporter-action v2 for CI}

[github-actions]

Size Change: +142 B (+0.23%)

Total Size: 62.4 kB

Filename	Size	Change
dist/preact.js	4.72 kB	+24 B (+0.51%)
dist/preact.min.js	4.73 kB	+23 B (+0.49%)
dist/preact.min.module.js	4.75 kB	+23 B (+0.49%)
dist/preact.min.umd.js	4.76 kB	+22 B (+0.46%)
dist/preact.module.js	4.74 kB	+27 B (+0.57%)
dist/preact.umd.js	4.78 kB	+23 B (+0.48%)

ℹ️ View Unchanged

Filename	Size
compat/dist/compat.js	4.13 kB
compat/dist/compat.module.js	4.06 kB
compat/dist/compat.umd.js	4.19 kB
debug/dist/debug.js	3.82 kB
debug/dist/debug.module.js	3.83 kB
debug/dist/debug.umd.js	3.9 kB
devtools/dist/devtools.js	260 B
devtools/dist/devtools.module.js	274 B
devtools/dist/devtools.umd.js	346 B
hooks/dist/hooks.js	1.52 kB
hooks/dist/hooks.module.js	1.56 kB
hooks/dist/hooks.umd.js	1.6 kB
jsx-runtime/dist/jsxRuntime.js	973 B
jsx-runtime/dist/jsxRuntime.module.js	947 B
jsx-runtime/dist/jsxRuntime.umd.js	1.05 kB
test-utils/dist/testUtils.js	451 B
test-utils/dist/testUtils.module.js	456 B
test-utils/dist/testUtils.umd.js	536 B

_{compressed-size-action}

[coveralls]

coverage: 99.488% (+0.001%) from 99.487%
when pulling 38080ea on handle-errors-during-hydration
into 6590e26 on main.