Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix demo #4551

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Fix demo #4551

merged 1 commit into from
Nov 11, 2024

Conversation

JoviDeCroock
Copy link
Member

Supersedes #4458
Fixes #4457

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 11, 2024 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -0% - +0% (-3.03ms - +1.51ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.04ms - +0.02ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -5% - +3% (-3.64ms - +2.29ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -4% - +2% (-0.76ms - +0.27ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -2% - +2% (-1.20ms - +1.82ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -6% - +3% (-0.13ms - +0.06ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +4% (-0.38ms - +1.46ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -3% - +2% (-0.94ms - +0.84ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -1% - +2% (-0.01ms - +0.03ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +3% (-0.43ms - +0.42ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.02ms - +0.02ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +1% (-0.01ms - +0.03ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -0% - +1% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +1% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local929.16ms - 932.54ms-unsure 🔍
-0% - +0%
-3.03ms - +1.51ms
preact-main930.10ms - 933.12msunsure 🔍
-0% - +0%
-1.51ms - +3.03ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local25.28ms - 25.28ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main25.28ms - 25.28msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.53ms - 16.58ms-unsure 🔍
-0% - +0%
-0.04ms - +0.02ms
preact-main16.55ms - 16.59msunsure 🔍
-0% - +0%
-0.02ms - +0.04ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.67ms - 1.70ms-unsure 🔍
-1% - +2%
-0.01ms - +0.03ms
preact-main1.66ms - 1.69msunsure 🔍
-2% - +1%
-0.03ms - +0.01ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local74.50ms - 77.36ms-unsure 🔍
-5% - +3%
-3.64ms - +2.29ms
preact-main74.01ms - 79.20msunsure 🔍
-3% - +5%
-2.29ms - +3.64ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local12.96ms - 13.54ms-unsure 🔍
-3% - +3%
-0.43ms - +0.42ms
preact-main12.94ms - 13.56msunsure 🔍
-3% - +3%
-0.42ms - +0.43ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.50ms - 16.86ms-unsure 🔍
-4% - +2%
-0.76ms - +0.27ms
preact-main16.45ms - 17.40msunsure 🔍
-2% - +5%
-0.27ms - +0.76ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local4.58ms - 4.60ms-unsure 🔍
-0% - +0%
-0.02ms - +0.02ms
preact-main4.58ms - 4.60msunsure 🔍
-0% - +0%
-0.02ms - +0.02ms		-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #4035

  • Commit: 22d61f0

duration

VersionAvg timevs preact-localvs preact-main
preact-local72.83ms - 74.93ms-unsure 🔍
-2% - +2%
-1.20ms - +1.82ms
preact-main72.48ms - 74.67msunsure 🔍
-2% - +2%
-1.82ms - +1.20ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.57ms - 3.60ms-unsure 🔍
-0% - +1%
-0.01ms - +0.03ms
preact-main3.56ms - 3.59msunsure 🔍
-1% - +0%
-0.03ms - +0.01ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local30.42ms - 31.08ms-unsure 🔍
-1% - +2%
-0.32ms - +0.62ms
preact-main30.26ms - 30.94msunsure 🔍
-2% - +1%
-0.62ms - +0.32ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local34.22ms - 35.44ms-unsure 🔍
-5% - +0%
-1.79ms - +0.11ms
preact-main34.94ms - 36.41msunsure 🔍
-0% - +5%
-0.11ms - +1.79ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local25.08ms - 25.48ms-unsure 🔍
-0% - +2%
-0.02ms - +0.51ms
preact-main24.86ms - 25.21msunsure 🔍
-2% - +0%
-0.51ms - +0.02ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local27.49ms - 29.34ms-unsure 🔍
-2% - +6%
-0.61ms - +1.79ms
preact-main27.06ms - 28.59msunsure 🔍
-6% - +2%
-1.79ms - +0.61ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local20.13ms - 20.65ms-unsure 🔍
-2% - +1%
-0.51ms - +0.29ms
preact-main20.20ms - 20.81msunsure 🔍
-1% - +3%
-0.29ms - +0.51ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local22.18ms - 22.73ms-unsure 🔍
-2% - +2%
-0.37ms - +0.43ms
preact-main22.13ms - 22.72msunsure 🔍
-2% - +2%
-0.43ms - +0.37ms		-
text-update
  • Browser: chrome-headless
  • Sample size: 230
  • Built by: CI #4035

  • Commit: 22d61f0

duration

VersionAvg timevs preact-localvs preact-main
preact-local2.04ms - 2.17ms-unsure 🔍
-6% - +3%
-0.13ms - +0.06ms
preact-main2.08ms - 2.21msunsure 🔍
-3% - +6%
-0.06ms - +0.13ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.11ms - 1.11ms-unsure 🔍
-0% - +1%
-0.00ms - +0.01ms
preact-main1.10ms - 1.11msunsure 🔍
-1% - +0%
-0.01ms - +0.00ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local33.20ms - 35.02ms-unsure 🔍
-1% - +4%
-0.38ms - +1.46ms
preact-main33.47ms - 33.67msunsure 🔍
-4% - +1%
-1.46ms - +0.38ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.22ms - 1.23ms-unsure 🔍
-0% - +1%
-0.00ms - +0.01ms
preact-main1.22ms - 1.22msunsure 🔍
-1% - +0%
-0.01ms - +0.00ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local34.62ms - 35.84ms-unsure 🔍
-3% - +2%
-0.94ms - +0.84ms
preact-main34.62ms - 35.92msunsure 🔍
-2% - +3%
-0.84ms - +0.94ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.52ms - 3.53ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-main3.51ms - 3.53msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms		-

tachometer-reporter-action v2 for CI

@github-actions GitHub Actions
Copy link

Size Change: +7 B (+0.01%)

Total Size: 62.3 kB

Filename Size Change
compat/dist/compat.js 4.13 kB +2 B (+0.05%)
compat/dist/compat.module.js 4.06 kB +4 B (+0.1%)
compat/dist/compat.umd.js 4.19 kB +1 B (+0.02%)
ℹ️ View Unchanged
Filename Size
debug/dist/debug.js 3.82 kB
debug/dist/debug.module.js 3.83 kB
debug/dist/debug.umd.js 3.9 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 346 B
dist/preact.js 4.69 kB
dist/preact.min.js 4.72 kB
dist/preact.min.module.js 4.72 kB
dist/preact.min.umd.js 4.75 kB
dist/preact.module.js 4.71 kB
dist/preact.umd.js 4.76 kB
hooks/dist/hooks.js 1.53 kB
hooks/dist/hooks.module.js 1.56 kB
hooks/dist/hooks.umd.js 1.6 kB
jsx-runtime/dist/jsxRuntime.js 976 B
jsx-runtime/dist/jsxRuntime.module.js 949 B
jsx-runtime/dist/jsxRuntime.umd.js 1.05 kB
test-utils/dist/testUtils.js 451 B
test-utils/dist/testUtils.module.js 456 B
test-utils/dist/testUtils.umd.js 536 B

compressed-size-action

@coveralls
Copy link

Coverage Status

coverage: 99.488%. remained the same
when pulling 22d61f0 on fix-demo
into 84dcf74 on main.

rschristian
rschristian approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I'm in favor of rm -rf ./demo at this point -- the value add is pretty unclear.

@JoviDeCroock
Copy link
Member Author

@rschristian I used it a lot to debug issues with libraries in the past, as it hot-reloads adjustments to the core files 😅

@JoviDeCroock JoviDeCroock merged commit e7610ef into main Nov 11, 2024
15 checks passed
@JoviDeCroock JoviDeCroock deleted the fix-demo branch November 11, 2024 07:14
@JoviDeCroock JoviDeCroock mentioned this pull request Nov 11, 2024
Closed
@JoviDeCroock JoviDeCroock mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschristian rschristian rschristian approved these changes

@marvinhagemeister marvinhagemeister Awaiting requested review from marvinhagemeister

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

preact demo won't run
3 participants
@JoviDeCroock @coveralls @rschristian