We should not always set to hydration #4529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoviDeCroock
requested review from
developit,
andrewiggins,
marvinhagemeister and
rschristian
JoviDeCroock
commented
Oct 12, 2024
rschristian
approved these changes
Oct 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4439
Currently we try to set everything to
hydratemode which feels like a mistake, we should only set the hydration flag when we are hydrating. I feel like we intended to set the SUSPENDED flag. This will make it so that we try to render the fallback rather than falling back to a non-suspended hydration mode, falling back to non-suspended hydration will clobber the DOM as we fall back to no excessDomChildren which is an inherent hydration mismatch.This is so because we skip this condition