Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

10.23.0 #4450

Merged
merged 1 commit into from
Jul 23, 2024
Merged

10.23.0 #4450

merged 1 commit into from
Jul 23, 2024

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Jul 20, 2024 •
edited
Loading

Features

This adds support for returning a function in functional refs, example

<input
  ref={(ref) => {
    // Assign ref, do something with it
    return () => {
      // ref cleanup, when the element unmounts
      // we run the cleanup
    };
  }}
/>

Fixes

Types

Maintenance

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 20, 2024 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +1% (-11.99ms - +7.63ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -3% - +3% (-0.43ms - +0.55ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +2% (-1.78ms - +1.05ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -2% - +3% (-0.31ms - +0.55ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -2% - +3% (-1.23ms - +2.20ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -5% - +4% (-0.09ms - +0.08ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +4% (-0.18ms - +0.97ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -1% - +1% (-0.44ms - +0.26ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - -0% (-0.01ms - -0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +1% (-0.28ms - +0.09ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +0% (-0.03ms - +0.02ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local865.87ms - 876.93ms-unsure 🔍
-1% - +1%
-11.99ms - +7.63ms
preact-main865.48ms - 881.68msunsure 🔍
-1% - +1%
-7.63ms - +11.99ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local25.15ms - 25.15ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main25.15ms - 25.15msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.77ms - 17.51ms-unsure 🔍
-3% - +3%
-0.43ms - +0.55ms
preact-main16.76ms - 17.40msunsure 🔍
-3% - +2%
-0.55ms - +0.43ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.69ms - 1.69ms-unsure 🔍
-0% - -0%
-0.01ms - -0.00ms
preact-main1.69ms - 1.70msunsure 🔍
+0% - +0%
+0.00ms - +0.01ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local65.94ms - 67.01ms-unsure 🔍
-3% - +2%
-1.78ms - +1.05ms
preact-main65.52ms - 68.15msunsure 🔍
-2% - +3%
-1.05ms - +1.78ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local15.49ms - 15.68ms-unsure 🔍
-2% - +1%
-0.28ms - +0.09ms
preact-main15.52ms - 15.85msunsure 🔍
-1% - +2%
-0.09ms - +0.28ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local17.14ms - 17.85ms-unsure 🔍
-2% - +3%
-0.31ms - +0.55ms
preact-main17.13ms - 17.62msunsure 🔍
-3% - +2%
-0.55ms - +0.31ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local4.62ms - 4.62ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main4.62ms - 4.62msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-
replace1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local73.93ms - 76.28ms-unsure 🔍
-2% - +3%
-1.23ms - +2.20ms
preact-main73.37ms - 75.87msunsure 🔍
-3% - +2%
-2.20ms - +1.23ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.52ms - 3.55ms-unsure 🔍
-1% - +0%
-0.03ms - +0.02ms
preact-main3.53ms - 3.56msunsure 🔍
-0% - +1%
-0.02ms - +0.03ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local28.77ms - 29.27ms-unsure 🔍
-1% - +1%
-0.34ms - +0.43ms
preact-main28.67ms - 29.27msunsure 🔍
-1% - +1%
-0.43ms - +0.34ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local33.91ms - 35.70ms-unsure 🔍
-6% - +2%
-1.96ms - +0.70ms
preact-main34.45ms - 36.42msunsure 🔍
-2% - +6%
-0.70ms - +1.96ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local25.05ms - 25.69ms-unsure 🔍
-2% - +1%
-0.44ms - +0.32ms
preact-main25.22ms - 25.63msunsure 🔍
-1% - +2%
-0.32ms - +0.44ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local29.59ms - 31.17ms-unsure 🔍
-3% - +4%
-0.82ms - +1.31ms
preact-main29.42ms - 30.85msunsure 🔍
-4% - +3%
-1.31ms - +0.82ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local22.66ms - 24.29ms-unsure 🔍
-5% - +4%
-1.27ms - +1.00ms
preact-main22.82ms - 24.40msunsure 🔍
-4% - +5%
-1.00ms - +1.27ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local23.64ms - 24.71ms-unsure 🔍
-1% - +5%
-0.18ms - +1.27ms
preact-main23.14ms - 24.12msunsure 🔍
-5% - +1%
-1.27ms - +0.18ms		-
text-update

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.94ms - 2.05ms-unsure 🔍
-5% - +4%
-0.09ms - +0.08ms
preact-main1.94ms - 2.06msunsure 🔍
-4% - +5%
-0.08ms - +0.09ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local0.98ms - 0.98ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main0.98ms - 0.98msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local25.72ms - 26.82ms-unsure 🔍
-1% - +4%
-0.18ms - +0.97ms
preact-main25.72ms - 26.03msunsure 🔍
-4% - +1%
-0.97ms - +0.18ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.25ms - 1.25ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main1.25ms - 1.25msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local31.60ms - 32.04ms-unsure 🔍
-1% - +1%
-0.44ms - +0.26ms
preact-main31.64ms - 32.18msunsure 🔍
-1% - +1%
-0.26ms - +0.44ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.55ms - 3.55ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main3.55ms - 3.55msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions GitHub Actions
Copy link

Size Change: +1 B (0%)

Total Size: 62 kB

Filename Size Change
devtools/dist/devtools.js 260 B +1 B (+0.39%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 4.1 kB
compat/dist/compat.module.js 4.03 kB
compat/dist/compat.umd.js 4.17 kB
debug/dist/debug.js 3.7 kB
debug/dist/debug.module.js 3.71 kB
debug/dist/debug.umd.js 3.78 kB
devtools/dist/devtools.module.js 273 B
devtools/dist/devtools.umd.js 345 B
dist/preact.js 4.72 kB
dist/preact.min.js 4.75 kB
dist/preact.min.module.js 4.75 kB
dist/preact.min.umd.js 4.77 kB
dist/preact.module.js 4.74 kB
dist/preact.umd.js 4.79 kB
hooks/dist/hooks.js 1.53 kB
hooks/dist/hooks.module.js 1.56 kB
hooks/dist/hooks.umd.js 1.6 kB
jsx-runtime/dist/jsxRuntime.js 981 B
jsx-runtime/dist/jsxRuntime.module.js 956 B
jsx-runtime/dist/jsxRuntime.umd.js 1.06 kB
test-utils/dist/testUtils.js 451 B
test-utils/dist/testUtils.module.js 456 B
test-utils/dist/testUtils.umd.js 536 B

compressed-size-action

@coveralls
Copy link

coveralls commented Jul 20, 2024 •
edited
Loading

Coverage Status

coverage: 99.486%. remained the same
when pulling 8e65f38 on 10.23.0
into f573891 on main.

@JoviDeCroock JoviDeCroock merged commit 2f1712a into main Jul 23, 2024
15 checks passed
@JoviDeCroock JoviDeCroock deleted the 10.23.0 branch July 23, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschristian rschristian rschristian approved these changes

@developit developit Awaiting requested review from developit

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

@marvinhagemeister marvinhagemeister Awaiting requested review from marvinhagemeister

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoviDeCroock @coveralls @rschristian