Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect "missing transform-jsx-source" warning #4350

Merged
merged 5 commits into from
Apr 30, 2024
Merged

fix: Incorrect "missing transform-jsx-source" warning #4350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
784af46
fix: Incorrect "missing `transform-jsx-source`" warning
rschristian Apr 26, 2024
61ce7a4
refactor: Slight rename
rschristian Apr 26, 2024
d4ff12e
test: Add test for fixed jsx-source warning
rschristian Apr 26, 2024
2e2f5ab
fix: Appease ESLint
rschristian Apr 26, 2024
50c3f3e
Merge branch 'main' into fix/jsx-source-debug-warning
rschristian Apr 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions debug/src/component-stack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export function getCurrentVNode() {
* location of a component. In that case we just omit that, but we'll
* print a helpful message to the console, notifying the user of it.
*/
let hasBabelPlugin = false;
let showJsxSourcePluginWarning = true;

/**
* Check if a `vnode` is a possible owner.
Expand Down Expand Up @@ -87,12 +87,12 @@ export function getOwnerStack(vnode) {
const source = owner.__source;
if (source) {
acc += ` (at ${source.fileName}:${source.lineNumber})`;
} else if (!hasBabelPlugin) {
hasBabelPlugin = true;
} else if (showJsxSourcePluginWarning) {
console.warn(
'Add @babel/plugin-transform-react-jsx-source to get a more detailed component stack. Note that you should not add it to production builds of your App for bundle size reasons.'
);
}
showJsxSourcePluginWarning = false;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea being that at this point we've either seen .__source or printed the warning, and in either case, we're now covered. hasBabelPlugin previously would only ever be set to true once the warning was shown.


return (acc += '\n');
}, '');
Expand Down
14 changes: 14 additions & 0 deletions debug/test/browser/component-stack.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,4 +83,18 @@ describe('component stack', () => {
expect(lines[1].indexOf('Thrower') > -1).to.equal(true);
expect(lines[2].indexOf('Bar') > -1).to.equal(true);
});

it('should not print a warning when "@babel/plugin-transform-react-jsx-source" is installed', () => {
function Thrower() {
throw new Error('foo');
}

try {
render(<Thrower />, scratch);
} catch {}

expect(warnings.join(' ')).to.not.include(
'@babel/plugin-transform-react-jsx-source'
);
});
});
Loading