Skip to content

Use Set #4325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shoonia wants to merge 1 commit into from
Closed

Use Set #4325

shoonia wants to merge 1 commit into from

Conversation

@shoonia
Copy link
Contributor

@shoonia shoonia commented Mar 25, 2024

No description provided.

@github-actions
Copy link

github-actions bot commented Mar 25, 2024 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -3% - +3% (-2.06ms - +2.62ms)
    preact-local vs preact-main
  • 03_update10th1k_x16: unsure 🔍 -3% - +4% (-1.00ms - +1.32ms)
    preact-local vs preact-main
  • 07_create10k: unsure 🔍 -0% - +1% (-4.43ms - +7.82ms)
    preact-local vs preact-main
  • filter_list: unsure 🔍 -1% - +0% (-0.11ms - +0.05ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +0% (-1.62ms - +0.31ms)
    preact-local vs preact-main
  • many_updates: unsure 🔍 -1% - +1% (-0.21ms - +0.21ms)
    preact-local vs preact-main
  • text_update: unsure 🔍 -3% - +3% (-0.08ms - +0.08ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -2% - +1% (-0.47ms - +0.21ms)
    preact-local vs preact-main

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • 07_create10k: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main

Results

02_replace1k

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main77.21ms - 81.10ms-unsure 🔍
-3% - +3%
-2.62ms - +2.06ms		unsure 🔍
-4% - +2%
-2.93ms - +1.81ms
preact-local78.12ms - 80.74msunsure 🔍
-3% - +3%
-2.06ms - +2.62ms		-unsure 🔍
-3% - +2%
-2.17ms - +1.60ms
preact-hooks78.36ms - 81.07msunsure 🔍
-2% - +4%
-1.81ms - +2.93ms		unsure 🔍
-2% - +3%
-1.60ms - +2.17ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main3.38ms - 3.39ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms		faster ✔
0% - 1%
0.01ms - 0.02ms
preact-local3.38ms - 3.39msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-faster ✔
0% - 1%
0.01ms - 0.02ms
preact-hooks3.40ms - 3.40msslower ❌
0% - 1%
0.01ms - 0.02ms		slower ❌
0% - 1%
0.01ms - 0.02ms		-

run-warmup-0

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main30.02ms - 31.03ms-unsure 🔍
-0% - +4%
-0.11ms - +1.18ms		unsure 🔍
-3% - +2%
-0.81ms - +0.49ms
preact-local29.59ms - 30.39msunsure 🔍
-4% - +0%
-1.18ms - +0.11ms		-faster ✔
0% - 4%
0.12ms - 1.27ms
preact-hooks30.28ms - 31.10msunsure 🔍
-2% - +3%
-0.49ms - +0.81ms		slower ❌
0% - 4%
0.12ms - 1.27ms		-

run-warmup-1

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main40.13ms - 41.70ms-unsure 🔍
-4% - +1%
-1.74ms - +0.28ms		faster ✔
1% - 5%
0.36ms - 2.17ms
preact-local41.01ms - 42.28msunsure 🔍
-1% - +4%
-0.28ms - +1.74ms		-unsure 🔍
-3% - +1%
-1.31ms - +0.24ms
preact-hooks41.74ms - 42.63msslower ❌
1% - 5%
0.36ms - 2.17ms		unsure 🔍
-1% - +3%
-0.24ms - +1.31ms		-

run-warmup-2

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main27.55ms - 28.15ms-unsure 🔍
-3% - +1%
-0.74ms - +0.33ms		unsure 🔍
-1% - +2%
-0.31ms - +0.49ms
preact-local27.61ms - 28.50msunsure 🔍
-1% - +3%
-0.33ms - +0.74ms		-unsure 🔍
-1% - +3%
-0.23ms - +0.81ms
preact-hooks27.50ms - 28.03msunsure 🔍
-2% - +1%
-0.49ms - +0.31ms		unsure 🔍
-3% - +1%
-0.81ms - +0.23ms		-

run-warmup-3

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main25.22ms - 26.06ms-unsure 🔍
-5% - +0%
-1.28ms - +0.13ms		unsure 🔍
-4% - +2%
-0.94ms - +0.43ms
preact-local25.65ms - 26.78msunsure 🔍
-1% - +5%
-0.13ms - +1.28ms		-unsure 🔍
-2% - +4%
-0.45ms - +1.10ms
preact-hooks25.35ms - 26.43msunsure 🔍
-2% - +4%
-0.43ms - +0.94ms		unsure 🔍
-4% - +2%
-1.10ms - +0.45ms		-

run-warmup-4

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main25.93ms - 26.87ms-faster ✔
1% - 6%
0.13ms - 1.72ms		faster ✔
5% - 10%
1.30ms - 2.83ms
preact-local26.69ms - 27.96msslower ❌
0% - 7%
0.13ms - 1.72ms		-faster ✔
1% - 7%
0.26ms - 2.01ms
preact-hooks27.86ms - 29.06msslower ❌
5% - 11%
1.30ms - 2.83ms		slower ❌
1% - 7%
0.26ms - 2.01ms		-

run-final

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main22.28ms - 22.99ms-unsure 🔍
-4% - +1%
-0.94ms - +0.17ms		faster ✔
4% - 10%
0.86ms - 2.43ms
preact-local22.60ms - 23.45msunsure 🔍
-1% - +4%
-0.17ms - +0.94ms		-faster ✔
2% - 8%
0.44ms - 2.08ms
preact-hooks23.59ms - 24.99msslower ❌
4% - 11%
0.86ms - 2.43ms		slower ❌
2% - 9%
0.44ms - 2.08ms		-
03_update10th1k_x16

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main32.19ms - 33.74ms-unsure 🔍
-4% - +3%
-1.32ms - +1.00ms		unsure 🔍
-4% - +2%
-1.50ms - +0.65ms
preact-local32.26ms - 33.99msunsure 🔍
-3% - +4%
-1.00ms - +1.32ms		-unsure 🔍
-4% - +3%
-1.40ms - +0.87ms
preact-hooks32.65ms - 34.13msunsure 🔍
-2% - +5%
-0.65ms - +1.50ms		unsure 🔍
-3% - +4%
-0.87ms - +1.40ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main3.35ms - 3.36ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms		faster ✔
0% - 1%
0.01ms - 0.02ms
preact-local3.35ms - 3.36msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-faster ✔
0% - 1%
0.01ms - 0.02ms
preact-hooks3.37ms - 3.38msslower ❌
0% - 1%
0.01ms - 0.02ms		slower ❌
0% - 1%
0.01ms - 0.02ms		-
07_create10k

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main906.33ms - 914.00ms-unsure 🔍
-1% - +0%
-7.82ms - +4.43ms		unsure 🔍
-1% - +1%
-12.90ms - +5.01ms
preact-local907.09ms - 916.63msunsure 🔍
-0% - +1%
-4.43ms - +7.82ms		-unsure 🔍
-1% - +1%
-11.65ms - +7.15ms
preact-hooks906.02ms - 922.21msunsure 🔍
-1% - +1%
-5.01ms - +12.90ms		unsure 🔍
-1% - +1%
-7.15ms - +11.65ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main26.16ms - 26.16ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms		unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-local26.16ms - 26.16msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks26.18ms - 26.18msunsure 🔍
+0% - +0%
+0.02ms - +0.02ms		unsure 🔍
+0% - +0%
+0.02ms - +0.02ms		-
filter_list

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main16.57ms - 16.69ms-unsure 🔍
-0% - +1%
-0.05ms - +0.11ms		unsure 🔍
-0% - +1%
-0.07ms - +0.09ms
preact-local16.56ms - 16.65msunsure 🔍
-1% - +0%
-0.11ms - +0.05ms		-unsure 🔍
-1% - +0%
-0.09ms - +0.05ms
preact-hooks16.57ms - 16.68msunsure 🔍
-1% - +0%
-0.09ms - +0.07ms		unsure 🔍
-0% - +1%
-0.05ms - +0.09ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main1.42ms - 1.42ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
1% - 2%
0.02ms - 0.03ms
preact-local1.42ms - 1.42msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
1% - 2%
0.02ms - 0.02ms
preact-hooks1.44ms - 1.44msslower ❌
1% - 2%
0.02ms - 0.03ms		slower ❌
1% - 2%
0.02ms - 0.02ms		-
hydrate1k

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main72.18ms - 74.09ms-unsure 🔍
-0% - +2%
-0.31ms - +1.62ms		unsure 🔍
-1% - +2%
-0.59ms - +1.50ms
preact-local72.31ms - 72.64msunsure 🔍
-2% - +0%
-1.62ms - +0.31ms		-unsure 🔍
-1% - +0%
-0.66ms - +0.26ms
preact-hooks72.25ms - 73.10msunsure 🔍
-2% - +1%
-1.50ms - +0.59ms		unsure 🔍
-0% - +1%
-0.26ms - +0.66ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main6.05ms - 6.05ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-local6.05ms - 6.05msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks6.07ms - 6.07msunsure 🔍
+0% - +0%
+0.02ms - +0.02ms		unsure 🔍
+0% - +0%
+0.02ms - +0.02ms		-
many_updates

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main16.45ms - 16.80ms-unsure 🔍
-1% - +1%
-0.21ms - +0.21ms		unsure 🔍
-1% - +1%
-0.21ms - +0.19ms
preact-local16.51ms - 16.73msunsure 🔍
-1% - +1%
-0.21ms - +0.21ms		-unsure 🔍
-1% - +1%
-0.15ms - +0.13ms
preact-hooks16.55ms - 16.72msunsure 🔍
-1% - +1%
-0.19ms - +0.21ms		unsure 🔍
-1% - +1%
-0.13ms - +0.15ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main4.52ms - 4.52ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-local4.52ms - 4.52msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks4.54ms - 4.54msunsure 🔍
+0% - +0%
+0.02ms - +0.02ms		unsure 🔍
+0% - +0%
+0.02ms - +0.02ms		-
text_update

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main2.49ms - 2.60ms-unsure 🔍
-3% - +3%
-0.08ms - +0.08ms		faster ✔
6% - 11%
0.15ms - 0.31ms
preact-local2.49ms - 2.61msunsure 🔍
-3% - +3%
-0.08ms - +0.08ms		-faster ✔
5% - 11%
0.14ms - 0.31ms
preact-hooks2.72ms - 2.83msslower ❌
6% - 12%
0.15ms - 0.31ms		slower ❌
5% - 12%
0.14ms - 0.31ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main0.80ms - 0.80ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
3% - 3%
0.02ms - 0.03ms
preact-local0.80ms - 0.80msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
3% - 3%
0.02ms - 0.03ms
preact-hooks0.83ms - 0.83msslower ❌
3% - 4%
0.02ms - 0.03ms		slower ❌
3% - 3%
0.02ms - 0.03ms		-
todo

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main27.72ms - 28.35ms-unsure 🔍
-1% - +2%
-0.21ms - +0.47ms		faster ✔
2% - 4%
0.56ms - 1.25ms
preact-local27.77ms - 28.04msunsure 🔍
-2% - +1%
-0.47ms - +0.21ms		-faster ✔
3% - 4%
0.84ms - 1.23ms
preact-hooks28.79ms - 29.08msslower ❌
2% - 5%
0.56ms - 1.25ms		slower ❌
3% - 4%
0.84ms - 1.23ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main0.88ms - 0.88ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms		faster ✔
3% - 3%
0.03ms - 0.03ms
preact-local0.88ms - 0.88msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-faster ✔
3% - 3%
0.03ms - 0.03ms
preact-hooks0.90ms - 0.90msslower ❌
3% - 3%
0.03ms - 0.03ms		slower ❌
3% - 3%
0.03ms - 0.03ms		-

tachometer-reporter-action v2 for Benchmarks

@coveralls
Copy link

coveralls commented Mar 25, 2024 •
edited
Loading

Coverage Status

coverage: 99.601%. remained the same
when pulling 1142558 on shoonia:use-set
into d3d57db on preactjs:main.

JoviDeCroock
JoviDeCroock reviewed Mar 25, 2024
View reviewed changes
src/diff/props.js
// per second for over 280 years before the value reaches Number.MAX_SAFE_INTEGER (2**53 - 1).
let eventClock = 0;

let p = new Set([
Copy link
Member

@JoviDeCroock JoviDeCroock Mar 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sets aren't supported in IE11 which Preact X still supports

Copy link
Contributor Author

@shoonia shoonia Mar 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any plans to stop supporting IE11?

Copy link
Member

@JoviDeCroock JoviDeCroock Mar 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would require a new major version

@shoonia shoonia closed this Mar 25, 2024
@shoonia shoonia deleted the use-set branch March 25, 2024 11:32
@rschristian rschristian mentioned this pull request Jan 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shoonia @coveralls @JoviDeCroock