Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip over function children when rendering #3919

Merged
merged 3 commits into from
Mar 2, 2023
Merged

Skip over function children when rendering #3919

merged 3 commits into from
Mar 2, 2023

Conversation

andrewiggins
Copy link
Member

Function children that are passed as props to a component are still allowed but if that Component doesn't invoke the function and passes it a child, we'll skip over it.

@github-actions
Copy link

github-actions bot commented Feb 28, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -2% - +2% (-3.91ms - +3.39ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -2% - +6% (-0.79ms - +2.08ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -2% - +1% (-26.17ms - +23.20ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +2% (-0.05ms - +0.46ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -1% - +2% (-1.61ms - +2.45ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -3% - +2% (-1.00ms - +0.60ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -5% - +0% (-0.21ms - +0.02ms)
    preact-local vs preact-master
  • todo: unsure 🔍 -2% - +2% (-1.14ms - +1.06ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -1% - +0% (-0.14ms - +0.04ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-master
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master156.21ms - 161.05ms-unsure 🔍
-2% - +2%
-3.39ms - +3.91ms		unsure 🔍
-3% - +2%
-4.43ms - +2.66ms
preact-local155.65ms - 161.10msunsure 🔍
-2% - +2%
-3.91ms - +3.39ms		-unsure 🔍
-3% - +2%
-4.91ms - +2.62ms
preact-hooks156.93ms - 162.11msunsure 🔍
-2% - +3%
-2.66ms - +4.43ms		unsure 🔍
-2% - +3%
-2.62ms - +4.91ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master3.38ms - 3.39ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms		faster ✔
1% - 1%
0.02ms - 0.03ms
preact-local3.39ms - 3.39msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-faster ✔
1% - 1%
0.02ms - 0.03ms
preact-hooks3.41ms - 3.42msslower ❌
1% - 1%
0.02ms - 0.03ms		slower ❌
1% - 1%
0.02ms - 0.03ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master55.02ms - 56.59ms-unsure 🔍
-2% - +3%
-0.86ms - +1.70ms		faster ✔
0% - 5%
0.18ms - 3.11ms
preact-local54.37ms - 56.40msunsure 🔍
-3% - +2%
-1.70ms - +0.86ms		-faster ✔
1% - 6%
0.46ms - 3.66ms
preact-hooks56.21ms - 58.68msslower ❌
0% - 6%
0.18ms - 3.11ms		slower ❌
1% - 7%
0.46ms - 3.66ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master81.01ms - 83.96ms-unsure 🔍
-3% - +2%
-2.20ms - +1.72ms		unsure 🔍
-3% - +2%
-2.30ms - +1.71ms
preact-local81.44ms - 84.02msunsure 🔍
-2% - +3%
-1.72ms - +2.20ms		-unsure 🔍
-2% - +2%
-1.93ms - +1.82ms
preact-hooks81.43ms - 84.14msunsure 🔍
-2% - +3%
-1.71ms - +2.30ms		unsure 🔍
-2% - +2%
-1.82ms - +1.93ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master58.30ms - 63.80ms-unsure 🔍
-5% - +7%
-2.97ms - +4.17ms		unsure 🔍
-2% - +10%
-0.93ms - +5.63ms
preact-local58.17ms - 62.72msunsure 🔍
-7% - +5%
-4.17ms - +2.97ms		-unsure 🔍
-2% - +8%
-1.15ms - +4.64ms
preact-hooks56.92ms - 60.49msunsure 🔍
-9% - +1%
-5.63ms - +0.93ms		unsure 🔍
-8% - +2%
-4.64ms - +1.15ms		-

run-warmup-3

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master69.14ms - 75.00ms-unsure 🔍
-6% - +6%
-4.02ms - +4.39ms		faster ✔
3% - 12%
2.22ms - 9.65ms
preact-local68.87ms - 74.90msunsure 🔍
-6% - +6%
-4.39ms - +4.02ms		-faster ✔
3% - 13%
2.34ms - 9.90ms
preact-hooks75.73ms - 80.29msslower ❌
3% - 14%
2.22ms - 9.65ms		slower ❌
3% - 14%
2.34ms - 9.90ms		-

run-warmup-4

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master74.47ms - 77.38ms-unsure 🔍
-3% - +4%
-2.02ms - +2.67ms		unsure 🔍
-4% - +2%
-2.72ms - +1.40ms
preact-local73.77ms - 77.43msunsure 🔍
-4% - +3%
-2.67ms - +2.02ms		-unsure 🔍
-4% - +2%
-3.33ms - +1.36ms
preact-hooks75.12ms - 78.04msunsure 🔍
-2% - +4%
-1.40ms - +2.72ms		unsure 🔍
-2% - +4%
-1.36ms - +3.33ms		-

run-final

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master46.38ms - 50.65ms-unsure 🔍
-7% - +6%
-3.27ms - +2.90ms		unsure 🔍
-11% - +2%
-5.44ms - +0.96ms
preact-local46.47ms - 50.93msunsure 🔍
-6% - +7%
-2.90ms - +3.27ms		-unsure 🔍
-10% - +2%
-5.32ms - +1.21ms
preact-hooks48.37ms - 53.15msunsure 🔍
-2% - +11%
-0.96ms - +5.44ms		unsure 🔍
-3% - +11%
-1.21ms - +5.32ms		-
03_update10th1k_x16

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master34.09ms - 36.04ms-unsure 🔍
-6% - +2%
-2.08ms - +0.79ms		unsure 🔍
-3% - +5%
-1.06ms - +1.66ms
preact-local34.66ms - 36.77msunsure 🔍
-2% - +6%
-0.79ms - +2.08ms		-unsure 🔍
-1% - +7%
-0.47ms - +2.37ms
preact-hooks33.82ms - 35.72msunsure 🔍
-5% - +3%
-1.66ms - +1.06ms		unsure 🔍
-7% - +1%
-2.37ms - +0.47ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master3.44ms - 3.45ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms		faster ✔
0% - 1%
0.01ms - 0.02ms
preact-local3.44ms - 3.45msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms		-faster ✔
0% - 1%
0.01ms - 0.02ms
preact-hooks3.46ms - 3.47msslower ❌
0% - 1%
0.01ms - 0.02ms		slower ❌
0% - 1%
0.01ms - 0.02ms		-
07_create10k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1581.61ms - 1617.83ms-unsure 🔍
-1% - +2%
-23.20ms - +26.17ms		unsure 🔍
-2% - +1%
-39.18ms - +13.00ms
preact-local1581.46ms - 1615.01msunsure 🔍
-2% - +1%
-26.17ms - +23.20ms		-unsure 🔍
-2% - +1%
-39.76ms - +10.60ms
preact-hooks1594.03ms - 1631.59msunsure 🔍
-1% - +2%
-13.00ms - +39.18ms		unsure 🔍
-1% - +2%
-10.60ms - +39.76ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master25.36ms - 25.36ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-local25.36ms - 25.36msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks25.38ms - 25.38msunsure 🔍
+0% - +0%
+0.02ms - +0.02ms		unsure 🔍
+0% - +0%
+0.02ms - +0.02ms		-
filter_list

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master22.60ms - 22.87ms-unsure 🔍
-2% - +0%
-0.46ms - +0.05ms		faster ✔
1% - 3%
0.13ms - 0.81ms
preact-local22.72ms - 23.16msunsure 🔍
-0% - +2%
-0.05ms - +0.46ms		-unsure 🔍
-3% - +0%
-0.64ms - +0.12ms
preact-hooks22.89ms - 23.52msslower ❌
1% - 4%
0.13ms - 0.81ms		unsure 🔍
-1% - +3%
-0.12ms - +0.64ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1.58ms - 1.58ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
1% - 1%
0.02ms - 0.02ms
preact-local1.58ms - 1.58msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
1% - 1%
0.02ms - 0.02ms
preact-hooks1.60ms - 1.60msslower ❌
1% - 1%
0.02ms - 0.02ms		slower ❌
1% - 1%
0.02ms - 0.02ms		-
hydrate1k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master109.97ms - 112.84ms-unsure 🔍
-2% - +1%
-2.45ms - +1.61ms		unsure 🔍
-4% - +1%
-4.09ms - +0.60ms
preact-local110.39ms - 113.26msunsure 🔍
-1% - +2%
-1.61ms - +2.45ms		-unsure 🔍
-3% - +1%
-3.67ms - +1.02ms
preact-hooks111.29ms - 115.01msunsure 🔍
-1% - +4%
-0.60ms - +4.09ms		unsure 🔍
-1% - +3%
-1.02ms - +3.67ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master18.18ms - 18.31ms-unsure 🔍
-0% - +1%
-0.04ms - +0.14ms		unsure 🔍
-1% - +2%
-0.13ms - +0.45ms
preact-local18.13ms - 18.26msunsure 🔍
-1% - +0%
-0.14ms - +0.04ms		-unsure 🔍
-1% - +2%
-0.18ms - +0.40ms
preact-hooks17.81ms - 18.37msunsure 🔍
-2% - +1%
-0.45ms - +0.13ms		unsure 🔍
-2% - +1%
-0.40ms - +0.18ms		-
many_updates

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master30.52ms - 31.55ms-unsure 🔍
-2% - +3%
-0.60ms - +1.00ms		unsure 🔍
-3% - +2%
-0.81ms - +0.58ms
preact-local30.23ms - 31.44msunsure 🔍
-3% - +2%
-1.00ms - +0.60ms		-unsure 🔍
-3% - +1%
-1.08ms - +0.45ms
preact-hooks30.69ms - 31.61msunsure 🔍
-2% - +3%
-0.58ms - +0.81ms		unsure 🔍
-1% - +4%
-0.45ms - +1.08ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master4.62ms - 4.63ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms		faster ✔
0% - 1%
0.02ms - 0.03ms
preact-local4.63ms - 4.63msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks4.65ms - 4.65msslower ❌
0% - 1%
0.02ms - 0.03ms		unsure 🔍
+0% - +0%
+0.02ms - +0.02ms		-
text_update

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master3.78ms - 3.96ms-unsure 🔍
-0% - +6%
-0.02ms - +0.21ms		unsure 🔍
-5% - +2%
-0.19ms - +0.08ms
preact-local3.71ms - 3.84msunsure 🔍
-5% - +0%
-0.21ms - +0.02ms		-faster ✔
1% - 7%
0.03ms - 0.27ms
preact-hooks3.83ms - 4.02msunsure 🔍
-2% - +5%
-0.08ms - +0.19ms		slower ❌
1% - 7%
0.03ms - 0.27ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.81ms - 0.81ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms		faster ✔
2% - 2%
0.01ms - 0.01ms
preact-local0.81ms - 0.81msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-faster ✔
2% - 2%
0.01ms - 0.01ms
preact-hooks0.83ms - 0.83msslower ❌
2% - 2%
0.01ms - 0.01ms		slower ❌
2% - 2%
0.01ms - 0.01ms		-
todo

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master62.97ms - 64.35ms-unsure 🔍
-2% - +2%
-1.06ms - +1.14ms		faster ✔
1% - 4%
0.81ms - 2.96ms
preact-local62.77ms - 64.47msunsure 🔍
-2% - +2%
-1.14ms - +1.06ms		-faster ✔
1% - 5%
0.74ms - 3.11ms
preact-hooks64.72ms - 66.37msslower ❌
1% - 5%
0.81ms - 2.96ms		slower ❌
1% - 5%
0.74ms - 3.11ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1.07ms - 1.07ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
2% - 2%
0.02ms - 0.03ms
preact-local1.06ms - 1.07msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
2% - 2%
0.03ms - 0.03ms
preact-hooks1.09ms - 1.09msslower ❌
2% - 2%
0.02ms - 0.03ms		slower ❌
2% - 3%
0.03ms - 0.03ms		-

tachometer-reporter-action v2 for Benchmarks

@coveralls
Copy link

Coverage Status

Coverage: 99.542%. Remained the same when pulling 83d8d7f on prevent-function-child-rendering into bf39376 on master.

@coveralls
Copy link

coveralls commented Feb 28, 2023 •
edited
Loading

Coverage Status

Coverage: 99.543%. Remained the same when pulling 56cc076 on prevent-function-child-rendering into 5b7fb23 on master.

@github-actions
Copy link

github-actions bot commented Feb 28, 2023 •
edited
Loading

Size Change: +17 B (0%)

Total Size: 54.1 kB

Filename Size Change
dist/preact.js 4.21 kB +2 B (0%)
dist/preact.min.js 4.24 kB +4 B (0%)
dist/preact.min.module.js 4.24 kB +1 B
dist/preact.min.umd.js 4.27 kB +3 B (0%)
dist/preact.module.js 4.23 kB +4 B (0%)
dist/preact.umd.js 4.28 kB +3 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.89 kB 0 B
compat/dist/compat.module.js 3.82 kB 0 B
compat/dist/compat.umd.js 3.96 kB 0 B
debug/dist/debug.js 3 kB 0 B
debug/dist/debug.module.js 3.01 kB 0 B
debug/dist/debug.umd.js 3.08 kB 0 B
devtools/dist/devtools.js 231 B 0 B
devtools/dist/devtools.module.js 240 B 0 B
devtools/dist/devtools.umd.js 314 B 0 B
hooks/dist/hooks.js 1.49 kB 0 B
hooks/dist/hooks.module.js 1.52 kB 0 B
hooks/dist/hooks.umd.js 1.57 kB 0 B
jsx-runtime/dist/jsxRuntime.js 360 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 326 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 441 B 0 B
test-utils/dist/testUtils.js 442 B 0 B
test-utils/dist/testUtils.module.js 444 B 0 B
test-utils/dist/testUtils.umd.js 526 B 0 B

compressed-size-action

@andrewiggins andrewiggins merged commit 15f0c96 into master Mar 2, 2023
@andrewiggins andrewiggins deleted the prevent-function-child-rendering branch March 2, 2023 23:08
JoviDeCroock added a commit that referenced this pull request Jan 16, 2024
@JoviDeCroock
backport #3919
3abc062
JoviDeCroock added a commit that referenced this pull request Jan 16, 2024
@JoviDeCroock
V11 update 10 13 (#4257)
4601cf3 
* backport #3911

* backport #3906

* backport #3837

* backport #3908

* backport #3904

* backport #3905

* backport #3898

* backport #3910

* backport #3948

* backport #3941

* backport #3945

* backport #3919

* backport #3922

* backport #3921

* backport #3903

* fix lint

* update more

* debug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andrewiggins @coveralls @marvinhagemeister @JoviDeCroock