Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass inEvent so custom debouncers can mirror our logic #3909

Merged
merged 1 commit into from
Feb 21, 2023
Merged

pass inEvent so custom debouncers can mirror our logic #3909

merged 1 commit into from
Feb 21, 2023

Conversation

JoviDeCroock
Copy link
Member

fixes #3902

@github-actions
Copy link

github-actions bot commented Feb 21, 2023 •
edited

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -3% - +2% (-3.57ms - +2.81ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -2% - +7% (-0.60ms - +2.31ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -1% - +0% (-11.88ms - +5.69ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -3% - +1% (-0.72ms - +0.19ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -1% - +2% (-1.30ms - +1.76ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -4% - +2% (-1.49ms - +0.67ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -1% - +3% (-0.05ms - +0.10ms)
    preact-local vs preact-master
  • todo: unsure 🔍 -2% - +2% (-0.83ms - +1.01ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -2% - +6% (-0.06ms - +0.22ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -7% - +3% (-0.91ms - +0.37ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-master
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master123.49ms - 127.94ms-unsure 🔍
-2% - +3%
-2.81ms - +3.57ms		unsure 🔍
-3% - +2%
-3.36ms - +2.80ms
preact-local123.05ms - 127.61msunsure 🔍
-3% - +2%
-3.57ms - +2.81ms		-unsure 🔍
-3% - +2%
-3.78ms - +2.45ms
preact-hooks123.87ms - 128.11msunsure 🔍
-2% - +3%
-2.80ms - +3.36ms		unsure 🔍
-2% - +3%
-2.45ms - +3.78ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master3.38ms - 3.39ms-unsure 🔍
-6% - +2%
-0.22ms - +0.06ms		faster ✔
1% - 1%
0.02ms - 0.03ms
preact-local3.32ms - 3.60msunsure 🔍
-2% - +6%
-0.06ms - +0.22ms		-unsure 🔍
-3% - +6%
-0.09ms - +0.19ms
preact-hooks3.41ms - 3.41msslower ❌
1% - 1%
0.02ms - 0.03ms		unsure 🔍
-6% - +3%
-0.19ms - +0.09ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master45.67ms - 46.89ms-unsure 🔍
-0% - +4%
-0.11ms - +1.91ms		faster ✔
1% - 5%
0.61ms - 2.59ms
preact-local44.57ms - 46.19msunsure 🔍
-4% - +0%
-1.91ms - +0.11ms		-faster ✔
3% - 8%
1.38ms - 3.62ms
preact-hooks47.10ms - 48.65msslower ❌
1% - 6%
0.61ms - 2.59ms		slower ❌
3% - 8%
1.38ms - 3.62ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master66.61ms - 68.45ms-unsure 🔍
-2% - +1%
-1.55ms - +0.99ms		unsure 🔍
-3% - +1%
-1.99ms - +0.73ms
preact-local66.94ms - 68.69msunsure 🔍
-1% - +2%
-0.99ms - +1.55ms		-unsure 🔍
-2% - +1%
-1.68ms - +0.98ms
preact-hooks67.16ms - 69.16msunsure 🔍
-1% - +3%
-0.73ms - +1.99ms		unsure 🔍
-1% - +2%
-0.98ms - +1.68ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master47.01ms - 51.14ms-unsure 🔍
-1% - +10%
-0.63ms - +4.75ms		unsure 🔍
-7% - +5%
-3.69ms - +2.41ms
preact-local45.28ms - 48.74msunsure 🔍
-10% - +1%
-4.75ms - +0.63ms		-unsure 🔍
-11% - +0%
-5.54ms - +0.14ms
preact-hooks47.46ms - 51.97msunsure 🔍
-5% - +8%
-2.41ms - +3.69ms		unsure 🔍
-0% - +12%
-0.14ms - +5.54ms		-

run-warmup-3

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master54.84ms - 59.71ms-unsure 🔍
-9% - +1%
-5.68ms - +0.74ms		unsure 🔍
-10% - +2%
-6.13ms - +1.08ms
preact-local57.66ms - 61.84msunsure 🔍
-1% - +10%
-0.74ms - +5.68ms		-unsure 🔍
-6% - +6%
-3.44ms - +3.33ms
preact-hooks57.14ms - 62.46msunsure 🔍
-2% - +11%
-1.08ms - +6.13ms		unsure 🔍
-6% - +6%
-3.33ms - +3.44ms		-

run-warmup-4

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master59.57ms - 61.16ms-unsure 🔍
-3% - +1%
-1.57ms - +0.73ms		unsure 🔍
-4% - +0%
-2.56ms - +0.18ms
preact-local59.95ms - 61.63msunsure 🔍
-1% - +3%
-0.73ms - +1.57ms		-unsure 🔍
-3% - +1%
-2.16ms - +0.62ms
preact-hooks60.45ms - 62.67msunsure 🔍
-0% - +4%
-0.18ms - +2.56ms		unsure 🔍
-1% - +4%
-0.62ms - +2.16ms		-

run-final

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master37.40ms - 41.31ms-unsure 🔍
-10% - +4%
-3.89ms - +1.70ms		unsure 🔍
-9% - +4%
-3.80ms - +1.85ms
preact-local38.45ms - 42.45msunsure 🔍
-4% - +10%
-1.70ms - +3.89ms		-unsure 🔍
-7% - +7%
-2.73ms - +2.98ms
preact-hooks38.29ms - 42.37msunsure 🔍
-5% - +10%
-1.85ms - +3.80ms		unsure 🔍
-7% - +7%
-2.98ms - +2.73ms		-
03_update10th1k_x16

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master33.45ms - 35.52ms-unsure 🔍
-6% - +2%
-2.31ms - +0.60ms		unsure 🔍
-4% - +4%
-1.48ms - +1.45ms
preact-local34.32ms - 36.36msunsure 🔍
-2% - +7%
-0.60ms - +2.31ms		-unsure 🔍
-2% - +7%
-0.61ms - +2.29ms
preact-hooks33.47ms - 35.54msunsure 🔍
-4% - +4%
-1.45ms - +1.48ms		unsure 🔍
-6% - +2%
-2.29ms - +0.61ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master3.44ms - 3.45ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms		faster ✔
0% - 1%
0.01ms - 0.03ms
preact-local3.45ms - 3.45msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-faster ✔
0% - 1%
0.01ms - 0.02ms
preact-hooks3.46ms - 3.47msslower ❌
0% - 1%
0.01ms - 0.03ms		slower ❌
0% - 1%
0.01ms - 0.02ms		-
07_create10k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1219.82ms - 1233.55ms-unsure 🔍
-0% - +1%
-5.69ms - +11.88ms		unsure 🔍
-1% - +0%
-13.20ms - +4.95ms
preact-local1218.11ms - 1229.07msunsure 🔍
-1% - +0%
-11.88ms - +5.69ms		-unsure 🔍
-1% - +0%
-15.30ms - +0.86ms
preact-hooks1224.87ms - 1236.75msunsure 🔍
-0% - +1%
-4.95ms - +13.20ms		unsure 🔍
-0% - +1%
-0.86ms - +15.30ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master25.36ms - 25.36ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-local25.36ms - 25.36msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks25.38ms - 25.38msunsure 🔍
+0% - +0%
+0.02ms - +0.02ms		unsure 🔍
+0% - +0%
+0.02ms - +0.02ms		-
filter_list

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master21.53ms - 22.39ms-unsure 🔍
-1% - +3%
-0.19ms - +0.72ms		unsure 🔍
-1% - +3%
-0.27ms - +0.65ms
preact-local21.57ms - 21.83msunsure 🔍
-3% - +1%
-0.72ms - +0.19ms		-unsure 🔍
-1% - +1%
-0.27ms - +0.13ms
preact-hooks21.62ms - 21.92msunsure 🔍
-3% - +1%
-0.65ms - +0.27ms		unsure 🔍
-1% - +1%
-0.13ms - +0.27ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1.58ms - 1.58ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
1% - 1%
0.02ms - 0.02ms
preact-local1.58ms - 1.58msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
1% - 1%
0.02ms - 0.02ms
preact-hooks1.60ms - 1.60msslower ❌
1% - 1%
0.02ms - 0.02ms		slower ❌
1% - 1%
0.02ms - 0.02ms		-
hydrate1k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master114.30ms - 116.35ms-unsure 🔍
-2% - +1%
-1.76ms - +1.30ms		unsure 🔍
-1% - +1%
-1.39ms - +1.61ms
preact-local114.41ms - 116.69msunsure 🔍
-1% - +2%
-1.30ms - +1.76ms		-unsure 🔍
-1% - +2%
-1.24ms - +1.91ms
preact-hooks114.12ms - 116.30msunsure 🔍
-1% - +1%
-1.61ms - +1.39ms		unsure 🔍
-2% - +1%
-1.91ms - +1.24ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master12.35ms - 13.31ms-unsure 🔍
-3% - +7%
-0.37ms - +0.91ms		unsure 🔍
-1% - +9%
-0.17ms - +1.14ms
preact-local12.13ms - 12.99msunsure 🔍
-7% - +3%
-0.91ms - +0.37ms		-unsure 🔍
-3% - +7%
-0.41ms - +0.84ms
preact-hooks11.90ms - 12.79msunsure 🔍
-9% - +1%
-1.14ms - +0.17ms		unsure 🔍
-7% - +3%
-0.84ms - +0.41ms		-
many_updates

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master37.22ms - 38.83ms-unsure 🔍
-2% - +4%
-0.67ms - +1.49ms		unsure 🔍
-2% - +4%
-0.59ms - +1.49ms
preact-local36.90ms - 38.33msunsure 🔍
-4% - +2%
-1.49ms - +0.67ms		-unsure 🔍
-2% - +3%
-0.93ms - +1.01ms
preact-hooks36.92ms - 38.23msunsure 🔍
-4% - +2%
-1.49ms - +0.59ms		unsure 🔍
-3% - +2%
-1.01ms - +0.93ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master4.63ms - 4.63ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-local4.62ms - 4.63msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks4.65ms - 4.65msunsure 🔍
+0% - +0%
+0.02ms - +0.02ms		unsure 🔍
+0% - +0%
+0.02ms - +0.02ms		-
text_update

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master3.44ms - 3.54ms-unsure 🔍
-3% - +1%
-0.10ms - +0.05ms		faster ✔
5% - 9%
0.18ms - 0.33ms
preact-local3.46ms - 3.57msunsure 🔍
-1% - +3%
-0.05ms - +0.10ms		-faster ✔
4% - 8%
0.15ms - 0.30ms
preact-hooks3.69ms - 3.80msslower ❌
5% - 9%
0.18ms - 0.33ms		slower ❌
4% - 9%
0.15ms - 0.30ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.81ms - 0.81ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms		faster ✔
2% - 2%
0.01ms - 0.01ms
preact-local0.81ms - 0.81msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-faster ✔
2% - 2%
0.01ms - 0.01ms
preact-hooks0.83ms - 0.83msslower ❌
2% - 2%
0.01ms - 0.01ms		slower ❌
2% - 2%
0.01ms - 0.01ms		-
todo

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master54.47ms - 55.76ms-unsure 🔍
-2% - +2%
-1.01ms - +0.83ms		faster ✔
1% - 4%
0.57ms - 2.55ms
preact-local54.55ms - 55.86msunsure 🔍
-2% - +2%
-0.83ms - +1.01ms		-faster ✔
1% - 4%
0.48ms - 2.47ms
preact-hooks55.93ms - 57.43msslower ❌
1% - 5%
0.57ms - 2.55ms		slower ❌
1% - 4%
0.48ms - 2.47ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1.06ms - 1.06ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
2% - 2%
0.02ms - 0.02ms
preact-local1.06ms - 1.06msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
2% - 2%
0.02ms - 0.02ms
preact-hooks1.08ms - 1.08msslower ❌
2% - 2%
0.02ms - 0.02ms		slower ❌
2% - 2%
0.02ms - 0.02ms		-

tachometer-reporter-action v2 for Benchmarks

JoviDeCroock
JoviDeCroock commented Feb 21, 2023
View reviewed changes
src/index.d.ts
vnode: ComponentChild,
parent: ContainerNode
): void;
export function hydrate(vnode: ComponentChild, parent: ContainerNode): void;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was prettier

@coveralls
Copy link

coveralls commented Feb 21, 2023 •
edited

Coverage Status

Coverage: 99.548%. Remained the same when pulling a9bf81f on pass-in-event into 17ce063 on master.

@github-actions
Copy link

Size Change: +12 B (0%)

Total Size: 54.2 kB

Filename Size Change
dist/preact.js 4.24 kB +2 B (0%)
dist/preact.min.js 4.26 kB +2 B (0%)
dist/preact.min.module.js 4.26 kB +2 B (0%)
dist/preact.min.umd.js 4.29 kB +2 B (0%)
dist/preact.module.js 4.25 kB +2 B (0%)
dist/preact.umd.js 4.31 kB +2 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.88 kB 0 B
compat/dist/compat.module.js 3.81 kB 0 B
compat/dist/compat.umd.js 3.94 kB 0 B
debug/dist/debug.js 3 kB 0 B
debug/dist/debug.module.js 3.01 kB 0 B
debug/dist/debug.umd.js 3.08 kB 0 B
devtools/dist/devtools.js 231 B 0 B
devtools/dist/devtools.module.js 240 B 0 B
devtools/dist/devtools.umd.js 314 B 0 B
hooks/dist/hooks.js 1.49 kB 0 B
hooks/dist/hooks.module.js 1.52 kB 0 B
hooks/dist/hooks.umd.js 1.57 kB 0 B
jsx-runtime/dist/jsxRuntime.js 360 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 326 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 441 B 0 B
test-utils/dist/testUtils.js 442 B 0 B
test-utils/dist/testUtils.module.js 444 B 0 B
test-utils/dist/testUtils.umd.js 526 B 0 B

compressed-size-action

@JoviDeCroock JoviDeCroock merged commit cc88ae6 into master Feb 21, 2023
@JoviDeCroock JoviDeCroock deleted the pass-in-event branch February 21, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass inEvent argument to a custom debounceRendering function
3 participants
@JoviDeCroock @coveralls @marvinhagemeister