Improve suspense test spies #3856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewiggins
requested review from
developit,
marvinhagemeister and
JoviDeCroock
marvinhagemeister
approved these changes
Jan 10, 2023
JoviDeCroock
added a commit
that referenced
this pull request
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working a bug & fix that impacts these tests and it's hard to debug them cuz as written, the error message doesn't log what method the spy assertion failed for. In the screenshots below can find it stack trace but in another branch, I don't see that 🤷♂️. It also lacks call information. So this PR rewrites how we spy on lifecycles so the method name is included in errors and the error message includes information about the calls to the method!
Before:
After:
