Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3679
Re-opens #3611
While working on this I did not realise that we have an override in our tests to make
JSX.Element
work https://github.com/preactjs/preact/blob/master/test/ts/jsx-namespacce-test.tsx#L7 which lead me to believe that TS constructs its own given theElementType
you export. This was wrong, this re-introduces the bug ofchildren
which is a more subtile issue with how we typedFunctionComponent
andClassComponent