undo jsx-element removal #3680
Merged
undo jsx-element removal #3680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvinhagemeister
approved these changes
Aug 19, 2022
piotr-cz
reviewed
Aug 19, 2022
| @@ -87,7 +87,7 @@ export type ComponentProps< | |||
| : never; | |||
|
|
|||
| export interface FunctionComponent<P = {}> { | |||
| (props: RenderableProps<P>, context?: any): ComponentChild; | |||
| (props: RenderableProps<P>, context?: any): VNode<any>; | |||
There was a problem hiding this comment.
This didn't revert return type to VNode<any> | null, as it was in v10.10.3
Returning null from components is valid, as described here:
React Docs > Preventing Component from Rendering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3679
Re-opens #3611
While working on this I did not realise that we have an override in our tests to make
JSX.Elementwork https://github.com/preactjs/preact/blob/master/test/ts/jsx-namespacce-test.tsx#L7 which lead me to believe that TS constructs its own given theElementTypeyou export. This was wrong, this re-introduces the bug ofchildrenwhich is a more subtile issue with how we typedFunctionComponentandClassComponent