Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hooks calling shouldComponentUpdate without context #3671

Merged
merged 2 commits into from
Aug 16, 2022
Merged

Fix hooks calling shouldComponentUpdate without context #3671

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e26b862
Fix hooks calling shouldComponentUpdate without context
developit Aug 15, 2022
80de59b
Fix `this` usage
developit Aug 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hooks/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ export function useReducer(reducer, initialState, init) {
// When we have no updated hooks in the component we invoke the previous SCU or
// traverse the VDOM tree further.
if (allHooksEmpty) {
return prevScu ? prevScu(p, s, c) : true;
return prevScu ? prevScu.call(this, p, s, c) : true;
developit marked this conversation as resolved.
Show resolved Hide resolved
}

// We check whether we have components with a nextValue set that
Expand All @@ -208,7 +208,7 @@ export function useReducer(reducer, initialState, init) {
});

if (!shouldSkipUpdating) {
return prevScu ? prevScu(p, s, c) : true;
return prevScu ? prevScu.call(this, p, s, c) : true;
}

// When all set nextValues are equal to their original value
Expand Down