Multiple state hooks in a component #3645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +180 B (0%) Total Size: 43.7 kB
ℹ️ View Unchanged
|
marvinhagemeister
approved these changes
Aug 5, 2022
| // we bail out of updating. | ||
| // Thinking: would this be dangerous with a batch of updates where | ||
| // Comp1 updates --> Comp2 updated in same batch twice but has same eventual state --> this leads to us | ||
| // not diving into Comp3 |
There was a problem hiding this comment.
Right now I can't come up with a scenario where that would break. We're already somewhat in edge case territory here with components being re-scheduled as part of the same commit. So I'd say let's keep on eye on that, but I don't expect there to be issues.
This was referenced Aug 5, 2022
Merged
This was referenced Aug 8, 2022
| // have values that aren't equal to one another this pushes | ||
| // us to update further down the tree | ||
| const shouldSkipUpdating = stateHooks.every(hookItem => { | ||
| if (!hookItem._nextValue) return true; |
There was a problem hiding this comment.
Per Marvin's comment above, shouldn't this check for _nextValue being undefined?
There was a problem hiding this comment.
_nextValue in this case is an array like the normal state hook containing [value, updater] so using ! is the least bytes and correct as it's array or undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the last sCU wins which basically means we are losing a bit of granularity, as well as filtering out React.memo when wrapped. The new flow looks like the following: