Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make demo compatible with node 16 and 18 #3617

Merged
merged 2 commits into from
Jul 15, 2022
Merged

fix: make demo compatible with node 16 and 18 #3617

merged 2 commits into from
Jul 15, 2022

Conversation

gengjiawen
Copy link
Contributor

@gengjiawen gengjiawen commented Jul 14, 2022 •
edited

mainly webpack and related deps upgrade.
Tested on node 16 and 18.

https://github.com/sass/node-sass/pull/3257 still not merged, so I make a patch to it.

replaced with sass.

marvinhagemeister
marvinhagemeister reviewed Jul 14, 2022
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you so much for the PR. Left a suggestion for the sass handling. Let me know what you think!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.454% when pulling 51abda3 on gengjiawen:node_latest into e960162 on preactjs:master.

JoviDeCroock
JoviDeCroock approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much 🙌

@JoviDeCroock JoviDeCroock merged commit cef315a into preactjs:master Jul 15, 2022
@gengjiawen gengjiawen deleted the node_latest branch July 15, 2022 06:07
This was referenced Aug 4, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister left review comments

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gengjiawen @coveralls @marvinhagemeister @JoviDeCroock