-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to setTimeout #3607
Merged
Merged
Switch to setTimeout #3607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the general correctness of DOM-events in Preact, micro-ticks are fired in-between events bubbling up and events firing. This means that when two similar events fire and both are setting state that one will fire set state rerender and then the other one will. Similarly if we fire an event that sets some dom and the ancestor of this eventTarget also has a similar listener _after_ dom manipulation we will bubble up and refire the event....
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Results07_create10k
duration
usedJSHeapSize
filter_list
duration
usedJSHeapSize
many_updates
duration
usedJSHeapSize
text_update
duration
usedJSHeapSize
todo
duration
usedJSHeapSize
|
Size Change: -11 B (0%) Total Size: 37.9 kB
ℹ️ View Unchanged
|
marvinhagemeister
approved these changes
Jul 7, 2022
JoviDeCroock
added a commit
that referenced
this pull request
Jul 7, 2022
This fixes a lot of issues with events as outlined in #3607
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the general correctness of DOM-events in Preact, micro-ticks are fired in-between events bubbling up and events firing. This means that when two similar events fire and both are setting state that one will fire set state rerender and then the other one will. Similarly if we fire an event that sets some dom and the ancestor of this eventTarget also has a similar listener after dom manipulation we will bubble up and refire the event....
We could leverage other DOM-techniques like
requestIdleCallback
but generally this seems to be a lot buggier, the only other thing left would be to write our own scheduler or use the DOM-scheduler API which looks experimentalExample issues
#3596
#2887
#2745